Re: [PATCH 1/2] MIPS: Compressed PLT/stubs support

Maciej W. Rozycki
2013-03-09T04:06:54Z

On Fri, 22 Feb 2013, Tom Tromey wrote:

> Alan> Hmm, perhaps a cleaner change would be implement make_msymbol_special
> Alan> for ppc64 and move the udata.p special case out of elf_symtab_read?
>
> Alan> Like so.
>
> Alan> * elfread.c (elf_symtab_read): Do not use udata.p here to find
> Alan> symbol size.
> Alan> * ppc64-tdep.c (ppc64_elf_make_msymbol_special): New function.
> Alan> * ppc64-tdep.h (ppc64_elf_make_msymbol_special): Declare.
> Alan> * ppc-linux-tdep.c (ppc_linux_init_abi): Set up to use the above.
> Alan> * ppcfbsd-tdep.c (ppcfbsd_init_abi): Likewise.
>
> I like this much better, thanks.
> This is ok.

Thanks for sorting this out -- now the MIPS change does not have to touch
elfread.c anymore.

Maciej