From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17914 invoked by alias); 15 Feb 2013 18:33:21 -0000 Received: (qmail 17858 invoked by uid 22791); 15 Feb 2013 18:33:19 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Feb 2013 18:33:11 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1FIX1Tt004103 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 15 Feb 2013 13:33:01 -0500 Received: from host2.jankratochvil.net (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1FIWuq7031499 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 15 Feb 2013 13:32:59 -0500 Date: Fri, 15 Feb 2013 18:33:00 -0000 From: Jan Kratochvil To: Eli Zaretskii Cc: markus.t.metzger@intel.com, gdb-patches@sourceware.org, markus.t.metzger@gmail.com Subject: Re: [rfc 6/8] record disas: omit function names by default Message-ID: <20130215183256.GA16845@host2.jankratochvil.net> References: <1360859352-30399-1-git-send-email-markus.t.metzger@intel.com> <1360859352-30399-7-git-send-email-markus.t.metzger@intel.com> <20130215161049.GA6219@host2.jankratochvil.net> <831uchtp4y.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <831uchtp4y.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00407.txt.bz2 On Fri, 15 Feb 2013 19:20:45 +0100, Eli Zaretskii wrote: > > record backtrace: > > Print function names from which instruction in the execution log ran. > > Isn't that just a backtrace? If so, I suggest > > Print a backtrace starting at the function to which the instruction > in the log belongs. That's the problem, the name "backtrace" itself is already a bit confusing. It is a "backtrace" into history, not into upper frames. (gdb) record backtrace _IO_vsnprintf _IO_vfprintf_internal strchrnul _IO_vfprintf_internal __GI__IO_default_xsputn You can see _IO_vfprintf_internal called strchrnul which then returned back to _IO_vfprintf_internal. This is not a real "backtrace". I was already considering renaming the command as the term is a bit overloaded in the debugger context. Maybe "record list-functions"? It is also very similar to the "record list" command there which lists lines: (gdb) btrace list 24-34 24 in stdio_file_flush () at ../../../git/gdb/ui-file.c:525-529 25 in ui_file_data () at ../../../git/gdb/ui-file.c:175-180 26 in stdio_file_flush () at ../../../git/gdb/ui-file.c:522-523 27 in gdb_flush () at ../../../git/gdb/ui-file.c:185 While I understand "record list" was trying to match the existing "list" command I do not find it too intuitive, so maybe "record list-lines"? Thanks, Jan