From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13281 invoked by alias); 14 Feb 2013 21:05:02 -0000 Received: (qmail 13271 invoked by uid 22791); 14 Feb 2013 21:05:01 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Feb 2013 21:04:54 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 10DB32E8F0; Thu, 14 Feb 2013 16:04:54 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id RupaQQ-XR3Ti; Thu, 14 Feb 2013 16:04:54 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CF0412E12D; Thu, 14 Feb 2013 16:04:53 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id BF4D0C162B; Thu, 14 Feb 2013 13:04:51 -0800 (PST) Date: Thu, 14 Feb 2013 21:05:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it. Message-ID: <20130214210451.GA4550@adacore.com> References: <20130214171404.2223.83713.stgit@brno.lan> <20130214171411.2223.32326.stgit@brno.lan> <87r4kiixbe.fsf@fleche.redhat.com> <511D2805.9050606@redhat.com> <87mwv6ix72.fsf@fleche.redhat.com> <511D2980.10703@redhat.com> <20130214185413.GJ17107@adacore.com> <877gmaiqg5.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877gmaiqg5.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00375.txt.bz2 > Joel> Lynx178 might also be an issue. Agreed on all other counts. > Joel> I was hoping that gnulib would be our saviour, but maybe it does not > Joel> implement everything we need (yet?). > > It has xstrndup, though it seems a bit weird to pull in 2 different > definitions of that function. Also, gnulib updates seem tricky right > now due to the libiconv situation. Yeah, I was definitely thinking more long term... If the libiconv situation is the only thing preventing us from doing an update, I'd go ahead, because the only known platform where this is known to potentially cause trouble is Lynx178, which I am going to guess is a fairly little used system. And AFAICT, working around the issue should be easily done by adding -DE...=... in CFLAGS when configuring the debugger. -- Joel