From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13294 invoked by alias); 14 Feb 2013 17:14:17 -0000 Received: (qmail 13283 invoked by uid 22791); 14 Feb 2013 17:14:14 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_CP X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Feb 2013 17:14:06 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1EHE6m9027308 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Feb 2013 12:14:06 -0500 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1EHE4xF009384 for ; Thu, 14 Feb 2013 12:14:05 -0500 Subject: [COMMIT PATCH 1/2] savestring: Rename parameter 'size' to 'len'. To: gdb-patches@sourceware.org From: Pedro Alves Date: Thu, 14 Feb 2013 17:14:00 -0000 Message-ID: <20130214171404.2223.83713.stgit@brno.lan> User-Agent: StGit/0.16 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00359.txt.bz2 It's better to avoid needless confusion, and call a string's length, length, instead of size, which is usually used to refer to sizeof of the string (len+1): size_t len = strlen (str); size_t size = sizeof (str); Tested on x86_64 Fedora 17. 2013-02-14 Pedro Alves * utils.c (savestring): Rename parameter 'size' to 'len'. --- gdb/utils.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/utils.c b/gdb/utils.c index 282ab8b..408c6ce 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -1186,17 +1186,17 @@ myread (int desc, char *addr, int len) return orglen; } -/* Make a copy of the string at PTR with SIZE characters +/* Make a copy of the string at PTR with LEN characters (and add a null character at the end in the copy). Uses malloc to get the space. Returns the address of the copy. */ char * -savestring (const char *ptr, size_t size) +savestring (const char *ptr, size_t len) { - char *p = (char *) xmalloc (size + 1); + char *p = (char *) xmalloc (len + 1); - memcpy (p, ptr, size); - p[size] = 0; + memcpy (p, ptr, len); + p[len] = 0; return p; }