[RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt)

Pierre Muller
2013-02-06T10:04:27Z

As announced in the previous email,
I would like to rediscuss the question
about removing the GNU/Linux rule.

Comments expected,

Pierre Muller
as ARI maintainer

2013-02-06 Pierre Muller <muller@sourceware.org>

* contrib/ari/gdb_ari.sh (GNU/Linux rule): Remove.

Index: contrib/ari/gdb_ari.sh
===================================================================
RCS file: /cvs/src/src/gdb/contrib/ari/gdb_ari.sh,v
retrieving revision 1.7
diff -u -p -r1.7 gdb_ari.sh
--- contrib/ari/gdb_ari.sh 1 Jan 2013 06:32:56 -0000 1.7
+++ contrib/ari/gdb_ari.sh 6 Feb 2013 10:01:03 -0000
@@ -257,21 +257,6 @@ BEGIN {

# Things in comments

-BEGIN { doc["GNU/Linux"] = "\
-Do not use `Linux'\'', instead use `Linux kernel'\'' or `GNU/Linux
system'\'';\
- comments should clearly differentiate between the two (this test assumes
that\
- word `Linux'\'' appears on the same line as the word `GNU'\'' or
`kernel'\''\
- or a kernel version"
- category["GNU/Linux"] = ari_comment
-}
-/(^|[^_[:alnum:]])Linux([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])Linux\[sic\]([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])GNU\/Linux([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])Linux [[:digit:]]\.[[:digit:]]+)/ {
- fail("GNU/Linux")
-}
-
BEGIN { doc["ARGSUSED"] = "\
Do not use ARGSUSED, unnecessary"
category["ARGSUSED"] = ari_regression

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pierre Muller
> Envoyé : mercredi 6 février 2013 10:59
> À : 'Sergio Durigan Junior'; gdb-patches@sourceware.org
> Objet : RE: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D
2013-02-05-gmt
>
> This issue has been discussed partly
> already in the thread:
>
> http://sourceware.org/ml/gdb-patches/2009-04/msg00286.html
>
> But I don't think that we really reached the point
> to agree that we should simply completely remove this
> rule.
>
> I will resubmit the removal as a separate email
> to see if we can agree on it.
>
>
> Pierre
> as ARI maintainer
>
>
> > -----Message d'origine-----
> > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > owner@sourceware.org] De la part de Sergio Durigan Junior
> > Envoyé : mercredi 6 février 2013 03:05
> > À : gdb-patches@sourceware.org
> > Objet : Re: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D
> 2013-02-05-gmt
> >
> > On Tuesday, February 05 2013, GDB Administrator wrote:
> >
> > >> gdb/gdbarch.h:740: comment: GNU/Linux: Do not use 'Linux', instead
use
> > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate
> > between the two (this test assumes that word 'Linux' appears on the same
> > line as the word 'GNU' or 'kernel' or a kernel version
> > > gdb/gdbarch.h:740:/* The elfcore writer hook to use to write Linux
> > prpsinfo notes to core
> > >> gdb/gdbarch.h:741: comment: GNU/Linux: Do not use 'Linux', instead
use
> > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate
> > between the two (this test assumes that word 'Linux' appears on the same
> > line as the word 'GNU' or 'kernel' or a kernel version
> > > gdb/gdbarch.h:741: files. Most Linux architectures use the same
> > prpsinfo32 or
> > >> gdb/gdbarch.h:743: comment: GNU/Linux: Do not use 'Linux', instead
use
> > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate
> > between the two (this test assumes that word 'Linux' appears on the same
> > line as the word 'GNU' or 'kernel' or a kernel version
> > > gdb/gdbarch.h:743: call the Linux generic routines in bfd to write
> > prpsinfo notes by
> > > 556a562
> >
> > These were introduced by the PRPSINFO patches, but I don't agree with
> > them (and don't see an elegant way to fix them). Is there any way to
> > silent those warnings?
> >
> > --
> > Sergio