Re: [rfc 5/5] record, disas: add record disassemble command

Jan Kratochvil
2013-02-10T22:11:38Z

On Fri, 08 Feb 2013 16:30:23 +0100, markus.t.metzger@intel.com wrote:
> * target.h (target_ops): Add to_disas_record and
> to_disas_record_range fields.
> (target_disas_record): New.
> (target_disas_record_range): New.
> * target.c (target_disas_record): New.
> (target_disas_record_range): New.
> * record.c: Include cli/cli-utils.h, disasm.h, ctype.h.
> (record_disas_size): New.
> (get_insn_number): New.
> (get_disas_modifiers): New.
> (cmd_record_disas): New.
> (_initialize_record): Add "set/show record disas-size" command.
> Add "record disassemble" command.

OK.

> diff --git a/gdb/target.h b/gdb/target.h
> index e4fe5da..bf0d825 100644
> --- a/gdb/target.h
> +++ b/gdb/target.h
> @@ -1983,4 +1989,10 @@ extern void target_goto_record_end (void);
> /* Go to a specific location in the recorded execution trace. */
> extern void target_goto_record (ULONGEST);
>
> +/* Disassemble the recorded execution trace. */

Likewise about comments, "See to_disas_record.".

> +extern void target_disas_record (int size, int flags);
> +
> +/* Disassemble a section of the recorded execution trace. */
> +extern void target_disas_record_range (ULONGEST begin, ULONGEST end, int flags);
> +
> #endif /* !defined (TARGET_H) */
> --
> 1.7.0.7