From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20424 invoked by alias); 11 Feb 2013 20:39:41 -0000 Received: (qmail 20340 invoked by uid 22791); 11 Feb 2013 20:39:40 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Feb 2013 20:39:37 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1BKdZsk018802 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 11 Feb 2013 15:39:35 -0500 Received: from host2.jankratochvil.net (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1BKdVaO032386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 11 Feb 2013 15:39:34 -0500 Date: Mon, 11 Feb 2013 20:39:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFC: fix PR symtab/11464 Message-ID: <20130211203930.GA26149@host2.jankratochvil.net> References: <87hamovmu7.fsf@fleche.redhat.com> <20130203054502.GB16948@host2.jankratochvil.net> <871ucw2g4p.fsf@fleche.redhat.com> <87fw1bzr8m.fsf@fleche.redhat.com> <20130207191514.GA24179@host2.jankratochvil.net> <87zjzappd6.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zjzappd6.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00258.txt.bz2 On Mon, 11 Feb 2013 21:28:05 +0100, Tom Tromey wrote: > This is quite strange. Today I rebased this patch onto gdb/master. > Then I built gdb without the patch and ran the test case that was > included in the patch. In gdb.log I then see: > > ptype gnu_obj_1::'~gnu_obj_1' > ERROR: Process no longer exists That's true, that crashes even for me. I still expected it crashes for you if you remove the two lines: if (classification == NAME) break; which cannot / does not crash. > Jan> So I still believe those two lines > Jan> if (classification == NAME) > Jan> break; > Jan> are just some cleanup/simplification but not required by this patch. > > Ok, I see what you mean, but the subsequent line is not valid for NAME: > > context_type = yylval.tsym.type; OK, that makes sense now. (It cannot crash but I agree it is not clean to read such data.) > I guess you are saying I should invert the if. > Ok, I will do that. No, I did not mean that. In fact I do not understand much what condition inversion do you mean. I am fine with the patch now. Thanks, Jan