Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Handle bitfields inside inner structs for internalvars
Date: Mon, 11 Feb 2013 18:11:00 -0000	[thread overview]
Message-ID: <20130211181135.GA21169@host2.jankratochvil.net> (raw)
In-Reply-To: <m3y5euhgjd.fsf@redhat.com>

On Mon, 11 Feb 2013 19:05:58 +0100, Sergio Durigan Junior wrote:
> On Saturday, February 09 2013, Jan Kratochvil wrote:
> > Otherwise I was curious - what to do if value_parent exists but TOVAL is not
> > a bitfield?  Isn't it a forgotten case?  (It is not but...)
> 
> According to comments in gdb/value.{c,h}, value_parent is only used iff
> the we are dealing with bitfields, so I guess this case is covered
> (otherwise it is a bug).  Was it a rhetorical question?

I expected a future reader may have such a question.

I just believed the code was worth some comment, thanks for it.  If it were
absolutely clear the bug would not happen there in the first place.


Thanks,
Jan


      reply	other threads:[~2013-02-11 18:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06 20:39 Sergio Durigan Junior
2013-02-08 20:47 ` Jan Kratochvil
2013-02-09  4:52   ` Sergio Durigan Junior
2013-02-09  7:39     ` Jan Kratochvil
2013-02-11 18:06       ` Sergio Durigan Junior
2013-02-11 18:11         ` Jan Kratochvil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130211181135.GA21169@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox