From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7046 invoked by alias); 8 Feb 2013 18:17:15 -0000 Received: (qmail 7020 invoked by uid 22791); 8 Feb 2013 18:17:14 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,MSGID_FROM_MTA_HEADER,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e06smtp13.uk.ibm.com (HELO e06smtp13.uk.ibm.com) (195.75.94.109) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Feb 2013 18:16:59 +0000 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Feb 2013 18:15:35 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 8 Feb 2013 18:15:19 -0000 Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r18IGXTL32178300 for ; Fri, 8 Feb 2013 18:16:33 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r18IGeSr006104 for ; Fri, 8 Feb 2013 11:16:41 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id r18IGd4s006087; Fri, 8 Feb 2013 11:16:39 -0700 Message-Id: <201302081816.r18IGd4s006087@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 08 Feb 2013 19:16:39 +0100 Subject: Re: [PATCH] Allow struct 'return' on 32-bit sparc. To: davem@davemloft.net (David Miller) Date: Fri, 08 Feb 2013 18:17:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, kettenis@gnu.org In-Reply-To: <20130201.161300.1158114789368969492.davem@davemloft.net> from "David Miller" at Feb 01, 2013 04:13:00 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit x-cbid: 13020818-2966-0000-0000-000006AE3FE9 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00219.txt.bz2 David Miller wrote: > void > return_command (char *retval_exp, int from_tty) > { > + enum return_value_convention rv_conv; > struct frame_info *thisframe; > struct gdbarch *gdbarch; > struct symbol *thisfun; This gives me: cc1: warnings being treated as errors /home/kwerner/dailybuild/spu-tc-2013-02-08/gdb-head/src/gdb/stack.c: In function 'return_command': /home/kwerner/dailybuild/spu-tc-2013-02-08/gdb-head/src/gdb/stack.c:2281: warning: 'rv_conv' may be used uninitialized in this function when building with GCC 4.1.2 (as of RHEL5). > @@ -2327,6 +2328,7 @@ return_command (char *retval_exp, int from_tty) > if (thisfun != NULL) > function = read_var_value (thisfun, thisframe); > > + rv_conv = RETURN_VALUE_REGISTER_CONVENTION; > if (TYPE_CODE (return_type) == TYPE_CODE_VOID) > /* If the return-type is "void", don't try to find the > return-value's location. However, do still evaluate the Maybe just move this up to the definition? Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com