From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6681 invoked by alias); 4 Feb 2013 18:59:28 -0000 Received: (qmail 6658 invoked by uid 22791); 4 Feb 2013 18:59:26 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Feb 2013 18:59:20 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id r14Ix3Pu011955; Mon, 4 Feb 2013 19:59:03 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id r14Ix296013414; Mon, 4 Feb 2013 19:59:02 +0100 (CET) Date: Mon, 04 Feb 2013 18:59:00 -0000 Message-Id: <201302041859.r14Ix296013414@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: palves@redhat.com CC: andreast-list@fgznet.ch, gdb-patches@sourceware.org In-reply-to: <510FFA52.9090503@redhat.com> (message from Pedro Alves on Mon, 04 Feb 2013 18:13:38 +0000) Subject: Re: [patch] revised FreeBSD PowerPC support References: <510C38DB.1020407@fgznet.ch> <510FFA52.9090503@redhat.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00090.txt.bz2 > Date: Mon, 04 Feb 2013 18:13:38 +0000 > From: Pedro Alves > > On 02/01/2013 09:51 PM, Andreas Tobler wrote: > > Index: ./ppcfbsd-tdep.h > > --- /dev/null > > +++ ./ppcfbsd-tdep.h > > @@ -0,0 +1,33 @@ > ... > > + > > +/* FreeBSD target descriptions. */ > > +extern struct target_desc *tdesc_powerpc_32l; > > +extern struct target_desc *tdesc_powerpc_64l; > > These look stale. > > Otherwise looks good to me. Didn't spot those. But the diff looks sane to me as well.