Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: tdaitx@linux.vnet.ibm.com (Tiago Stürmer Daitx)
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix handling of #include files during prologue skipping
Date: Thu, 24 Jan 2013 12:56:00 -0000	[thread overview]
Message-ID: <201301241256.r0OCueFI023763@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <1358997585.28026.56.camel@localhost.localdomain> from "Tiago =?ISO-8859-1?Q?St=FCrmer?= Daitx" at Jan 24, 2013 01:19:45 AM

Tiago Daitx wrote:

> I didn't include one since the header files in gdb.base that I looked at
> the time didn't have it. I checked it again and noticed that from all 11
> headers files in there only 1 has a copyright in it
> (gdb.base/included.h).
> 
> If a copyright is actually needed I will be happy to include one, so
> please let me know your answer.

If you do so, please keep in mind that the bug the test case triggered
depends on (relative) line number values, so please make sure the bug
actually still shows (with unpatched GDB) after you've added the
comment lines ...

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  parent reply	other threads:[~2013-01-24 12:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-23 20:34 Tiago Stürmer Daitx
2013-01-23 20:44 ` Tom Tromey
2013-01-24  0:52 ` Yao Qi
2013-01-24  3:19   ` Tiago Stürmer Daitx
2013-01-24  3:42     ` Yao Qi
2013-01-24  6:23     ` Joel Brobecker
2013-01-24 11:13       ` Pedro Alves
2013-01-24 12:56     ` Ulrich Weigand [this message]
2013-01-24 13:11       ` Tiago Stürmer Daitx
2013-01-24 14:28         ` Tiago Stürmer Daitx
2013-01-24 15:01           ` Tiago Stürmer Daitx
2013-01-24 15:12             ` Tom Tromey
2013-01-24 20:43               ` Tiago Stürmer Daitx
  -- strict thread matches above, loose matches on Subject: below --
2013-01-23 18:39 Tiago Stürmer Daitx
2013-01-23 19:30 ` Ulrich Weigand
2013-01-23 19:38 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201301241256.r0OCueFI023763@d06av02.portsmouth.uk.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdaitx@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox