From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8021 invoked by alias); 24 Jan 2013 06:23:49 -0000 Received: (qmail 8004 invoked by uid 22791); 24 Jan 2013 06:23:46 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Jan 2013 06:23:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A7C091C786B; Thu, 24 Jan 2013 01:23:40 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id wJgtGSGfoANj; Thu, 24 Jan 2013 01:23:40 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3F5C01C7673; Thu, 24 Jan 2013 01:23:40 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 85E55C23CC; Thu, 24 Jan 2013 10:23:33 +0400 (RET) Date: Thu, 24 Jan 2013 06:23:00 -0000 From: Joel Brobecker To: Tiago St?rmer Daitx Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix handling of #include files during prologue skipping Message-ID: <20130124062333.GA16749@adacore.com> References: <51004922.0VYgHGakDPQGcTqV%tdaitx@linux.vnet.ibm.com> <5100858F.1020809@codesourcery.com> <1358997585.28026.56.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1358997585.28026.56.camel@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00584.txt.bz2 > I didn't include one since the header files in gdb.base that I looked at > the time didn't have it. I checked it again and noticed that from all 11 > headers files in there only 1 has a copyright in it > (gdb.base/included.h). > > If a copyright is actually needed I will be happy to include one, so > please let me know your answer. Yes please. My understanding of the FSF procedures is that every file which contains significant material should have a copyright header, and my stance on this is that we should include one in every file. Your observation is also correct, and it needs to be fixed eventually. -- Joel