From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3443 invoked by alias); 22 Jan 2013 12:05:27 -0000 Received: (qmail 3425 invoked by uid 22791); 22 Jan 2013 12:05:25 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Jan 2013 12:05:19 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0MC5Gre020852 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Jan 2013 07:05:17 -0500 Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r0MC5BYC022499 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 22 Jan 2013 07:05:15 -0500 Date: Tue, 22 Jan 2013 12:05:00 -0000 From: Jan Kratochvil To: Eli Zaretskii Cc: tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [patch 4/9] TUI: Use internally fullname Message-ID: <20130122120511.GA10948@host2.jankratochvil.net> References: <20130117215935.GE16249@host2.jankratochvil.net> <87r4le1i04.fsf@fleche.redhat.com> <20130121211121.GA29177@host2.jankratochvil.net> <83mww1ogfl.fsf@gnu.org> <20130122071205.GA31510@host2.jankratochvil.net> <83a9s1oc9w.fsf@gnu.org> <20130122084648.GA2790@host2.jankratochvil.net> <83622po31d.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83622po31d.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00522.txt.bz2 On Tue, 22 Jan 2013 12:44:30 +0100, Eli Zaretskii wrote: > > It is compilation directory (DW_AT_comp_dir) relative name (therefore CU's > > DW_AT_name). > > But then it means that directory is somewhere we could get at it, > right? And yet you said "has no compilation directory". What am I > missing? It is doable but it is too expensive to resolve all the possible combinations. The compilation directory is (possibly) different for every CU (~= symtab). And due to the possibility of choosing arbitrary number of trailing path components you need to resolve it for each one. With 25000 source files, each one having approx. 10 path components, even after the not yet posted dropped xfullpath optimization it means 2500000 stat syscalls. This is 0.744s on my box just for the stat syscalls overhead, in GDB it would sure be higher. Sure this is all possible but I believe it is an add-on/different patchset than this one, it is appropriate to cache all the info some way. This patchset tries to fix some of the found bugs and rename some confusing variables/fields in GDB. > > Moreover recent GDBs allow to use also any trailing part, therefore not just > > "break ./gdb.base/return.c:main" and "break return.c:main" > > but also "break gdb.base/return.c". > > It sounds strange to me to use "." to mean anything but GDB's current > directory, but if that's a long living tradition, so be it. I have noticed it because whole testsuite uses the ./gdb.base/return.c names. Thanks, Jan