From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10662 invoked by alias); 21 Jan 2013 16:46:49 -0000 Received: (qmail 10650 invoked by uid 22791); 21 Jan 2013 16:46:47 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Jan 2013 16:46:37 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0LGkauo026018 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 Jan 2013 11:46:36 -0500 Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0LGkW2i002712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 21 Jan 2013 11:46:35 -0500 Date: Mon, 21 Jan 2013 16:46:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: [commit] [patch] Fix gdb.fortran/common-block.exp crash in PIE mode Message-ID: <20130121164632.GA15322@host2.jankratochvil.net> References: <20130119224534.GA26330@host2.jankratochvil.net> <874nia4iri.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874nia4iri.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00477.txt.bz2 On Mon, 21 Jan 2013 17:12:49 +0100, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > Jan> Fix gdb.fortran/common-block.exp crash in PIE mode. > Jan> * dwarf2read.c (new_symbol_full) : Use > Jan> LOC_COMMON_BLOCK. > Jan> * f-valprint.c (info_common_command_for_block): Expect > Jan> LOC_COMMON_BLOCK in gdb_assert. > Jan> * symtab.h (struct general_symbol_info): Update comment for the > Jan> common_block member. > Jan> (domain_enum): Extend comment for the COMMON_BLOCK_DOMAIN member. > Jan> (enum address_class): New member LOC_COMMON_BLOCK. > > Looks good to me. Checked in: http://sourceware.org/ml/gdb-cvs/2013-01/msg00123.html > Perhaps the various symbol-value accessors like SYMBOL_VALUE_ADDRESS > should make assertions about the address class. This is what GCC does > in its tree accessors. OK, I see no need for ({...}), I will post something later. Thanks, Jan