From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21544 invoked by alias); 17 Jan 2013 21:59:46 -0000 Received: (qmail 21535 invoked by uid 22791); 17 Jan 2013 21:59:45 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Jan 2013 21:59:40 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0HLxe5c015568 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 17 Jan 2013 16:59:40 -0500 Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0HLxZES020603 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Thu, 17 Jan 2013 16:59:38 -0500 Date: Thu, 17 Jan 2013 21:59:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [patch 4/9] TUI: Use internally fullname Message-ID: <20130117215935.GE16249@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00386.txt.bz2 Hi, TUI was using comp_dir-relative "filaname" during matching. Thanks, Jan 2013-01-15 Jan Kratochvil * tui/tui-data.c (init_win_info, tui_del_window, tui_free_window): Rename field reference filename to fullname. * tui/tui-data.h (struct tui_source_info): Rename field filename to fullname. New comment for it. * tui/tui-source.c (tui_set_source_content): Rename field reference filename to fullname. Initialize field by symtab_to_fullname now. * tui/tui-winsource.c (tui_update_breakpoint_info): Rename field reference filename to fullname. Use symtab_to_fullname during comparison. --- a/gdb/tui/tui-data.c +++ b/gdb/tui/tui-data.c @@ -541,7 +541,7 @@ init_win_info (struct tui_win_info *win_info) win_info->detail.source_info.gdbarch = NULL; win_info->detail.source_info.start_line_or_addr.loa = LOA_ADDRESS; win_info->detail.source_info.start_line_or_addr.u.addr = 0; - win_info->detail.source_info.filename = 0; + win_info->detail.source_info.fullname = NULL; break; case DATA_WIN: win_info->detail.data_display_info.data_content = (tui_win_content) NULL; @@ -681,10 +681,10 @@ tui_del_window (struct tui_win_info *win_info) generic_win->handle = (WINDOW *) NULL; generic_win->is_visible = FALSE; } - if (win_info->detail.source_info.filename) + if (win_info->detail.source_info.fullname) { - xfree (win_info->detail.source_info.filename); - win_info->detail.source_info.filename = 0; + xfree (win_info->detail.source_info.fullname); + win_info->detail.source_info.fullname = NULL; } generic_win = win_info->detail.source_info.execution_info; if (generic_win != (struct tui_gen_win_info *) NULL) @@ -731,10 +731,10 @@ tui_free_window (struct tui_win_info *win_info) generic_win->handle = (WINDOW *) NULL; } tui_free_win_content (generic_win); - if (win_info->detail.source_info.filename) + if (win_info->detail.source_info.fullname) { - xfree (win_info->detail.source_info.filename); - win_info->detail.source_info.filename = 0; + xfree (win_info->detail.source_info.fullname); + win_info->detail.source_info.fullname = NULL; } generic_win = win_info->detail.source_info.execution_info; if (generic_win != (struct tui_gen_win_info *) NULL) --- a/gdb/tui/tui-data.h +++ b/gdb/tui/tui-data.h @@ -270,7 +270,10 @@ struct tui_source_info struct tui_gen_win_info *execution_info; int horizontal_offset; /* Used for horizontal scroll. */ struct tui_line_or_address start_line_or_addr; - char *filename; + + /* It is the resolved form as returned by symtab_to_fullname. */ + char *fullname; + /* Architecture associated with code at this location. */ struct gdbarch *gdbarch; }; --- a/gdb/tui/tui-source.c +++ b/gdb/tui/tui-source.c @@ -99,9 +99,8 @@ tui_set_source_content (struct symtab *s, xfree (TUI_SRC_WIN->generic.title); TUI_SRC_WIN->generic.title = xstrdup (s->filename); - if (src->filename) - xfree (src->filename); - src->filename = xstrdup (s->filename); + xfree (src->fullname); + src->fullname = xstrdup (symtab_to_fullname (s)); /* Determine the threshold for the length of the line and the offset to start the display. */ --- a/gdb/tui/tui-winsource.c +++ b/gdb/tui/tui-winsource.c @@ -463,7 +463,8 @@ tui_update_breakpoint_info (struct tui_win_info *win, { if ((win == TUI_SRC_WIN && loc->symtab != NULL - && (filename_cmp (src->filename, loc->symtab->filename) == 0) + && filename_cmp (src->fullname, + symtab_to_fullname (loc->symtab)) == 0 && line->line_or_addr.loa == LOA_LINE && loc->line_number == line->line_or_addr.u.line_no) || (win == TUI_DISASM_WIN