From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22292 invoked by alias); 9 Jan 2013 12:37:22 -0000 Received: (qmail 22170 invoked by uid 22791); 9 Jan 2013 12:37:20 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Jan 2013 12:37:12 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r09CbAV3022830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 9 Jan 2013 07:37:10 -0500 Received: from host2.jankratochvil.net (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r09Cb64U010816 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 9 Jan 2013 07:37:09 -0500 Date: Wed, 09 Jan 2013 12:37:00 -0000 From: Jan Kratochvil To: Sanjoy Das Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Add a test case for the jit-reader interface. Message-ID: <20130109123706.GB6415@host2.jankratochvil.net> References: <1352048631-25042-1-git-send-email-sanjoy@playingwithpointers.com> <1352048631-25042-4-git-send-email-sanjoy@playingwithpointers.com> <20121201204751.GB22812@host2.jankratochvil.net> <20121210163800.GA24342@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00159.txt.bz2 On Tue, 08 Jan 2013 21:40:02 +0100, Sanjoy Das wrote: > > OK, that makes sense. But in such case please make there a clear separate > > jit.h copy (with a different name and some added #ifdef/#error or something > > like that protection so that if one mistakenly includes gdb/jit.h it gets > > error-reported, with an explanation you made to me now above). > > Fixed. > +#ifdef JIT_H > +#error "We don't include jit.h directly since we'd like the jit-reader unit \ > + tests to break if we make ABI incompatible changes to the structures \ > + re-declared here." > +#endif OK, thanks for the explanation, it looks clear to me now. > + gdb_test_no_output "jit-reader-load ${jit_reader_bin}" Do not use full binary path in test name, those differ across testsuite runs. That is use for example: gdb_test_no_output "jit-reader-load ${jit_reader_bin}" "jit-reader-load" Therefore these three parts are OK for check-in. There was a never-replied mail but that suggestion is not required for this check-in. Re: [PATCH 1/3] Fix segfault when unwinding JIT frames using a custom reader. http://sourceware.org/ml/gdb-patches/2012-12/msg00007.html Message-ID: <20121201202522.GA22812@host2.jankratochvil.net> Thanks, Jan