Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: x86: fix x32 builds with inline asm
Date: Tue, 08 Jan 2013 17:22:00 -0000	[thread overview]
Message-ID: <20130108172223.GA2601@host2.jankratochvil.net> (raw)
In-Reply-To: <201301081052.36180.vapier@gentoo.org>

On Tue, 08 Jan 2013 16:52:34 +0100, Mike Frysinger wrote:
> On Tuesday 08 January 2013 10:36:11 H.J. Lu wrote:
> > I think we should keep
> > 
> > #else
> > # error "!__i386__ && !__x86_64__"
> > #endif
> 
> that #else case is currently impossible to hit because the whole func is 
> protected by:
> #if defined __i386__ || defined __x86_64__
> 
> i'm guessing the #else was there only to make sure that some asm test was 
> performed, but since there is no conditional asm, that's no longer an issue

I agree and I do not mind either way.


Jan


  reply	other threads:[~2013-01-08 17:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-08 14:59 Mike Frysinger
2013-01-08 15:36 ` H.J. Lu
2013-01-08 15:50   ` Mike Frysinger
2013-01-08 17:22     ` Jan Kratochvil [this message]
2013-01-08 15:57 ` Mike Frysinger
2013-01-08 16:54   ` H.J. Lu
2013-01-08 17:42     ` Mike Frysinger
2013-01-08 17:50       ` H.J. Lu
2013-01-08 18:42 ` [PATCH v2] " Mike Frysinger
2013-01-08 18:52   ` Jan Kratochvil
2013-01-08 19:18     ` Mike Frysinger
2013-01-08 19:53       ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130108172223.GA2601@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=hjl.tools@gmail.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox