From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24711 invoked by alias); 4 Jan 2013 10:17:40 -0000 Received: (qmail 24695 invoked by uid 22791); 4 Jan 2013 10:17:38 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Jan 2013 10:17:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EFF472E518; Fri, 4 Jan 2013 05:17:34 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lrXTtEZcSgsP; Fri, 4 Jan 2013 05:17:34 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8B4352E0D2; Fri, 4 Jan 2013 05:17:34 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 9455FC2584; Fri, 4 Jan 2013 14:17:28 +0400 (RET) Date: Fri, 04 Jan 2013 10:17:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFC: add completion for "set gnutarget" Message-ID: <20130104101728.GA3703@adacore.com> References: <87zk0q5j4n.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zk0q5j4n.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00064.txt.bz2 > 2013-01-02 Tom Tromey > > * cli/cli-decode.c (add_setshow_string_noescape_cmd): Return the > set command. > * command.h (add_setshow_string_noescape_cmd): Update. > * corefile.c (set_gnutarget_command): Remove trailing whitespace. > (complete_set_gnutarget): New function. > (_initialize_core): Set the "set gnutarget" completer. > > 2013-01-02 Tom Tromey > > * gdb.base/completion.exp: Add "set gnutarget" test. FWIW, I took a look, and it looks fine to me too. -- Joel