From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1237 invoked by alias); 23 Dec 2012 06:47:53 -0000 Received: (qmail 1228 invoked by uid 22791); 23 Dec 2012 06:47:52 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 23 Dec 2012 06:47:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EB6692E1FF; Sun, 23 Dec 2012 01:47:42 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ThWPMViXcRNf; Sun, 23 Dec 2012 01:47:42 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7BFA31C7E27; Sun, 23 Dec 2012 01:47:42 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D90B3C255C; Sun, 23 Dec 2012 10:47:35 +0400 (RET) Date: Sun, 23 Dec 2012 06:47:00 -0000 From: Joel Brobecker To: Marcus Shawcroft Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH 1/5] AArch64 GDB and GDBSERVER Port V2 Message-ID: <20121223064735.GA25034@adacore.com> References: <50AD0303.5030100@arm.com> <50BCD288.4030109@arm.com> <20121223063407.GK5370@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121223063407.GK5370@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00786.txt.bz2 > > + if (tdep->jb_pc >= 0) > > + set_gdbarch_get_longjmp_target (gdbarch, aarch64_get_longjmp_target); > This code looks useless AFAICT, as tdep->jb_pc is set to -1 earlier > in this function, and I don't think anything changes its value before > this code. OK, I think you can ignore this comment. I just found the call to gdbarch_init_osabi just above it... -- Joel