RE: [RFC] Require extern modifier for function prototypes in headers.

Pierre Muller
2012-12-22T17:53:55Z

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Jan Kratochvil
> Envoyé : samedi 22 décembre 2012 13:54
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org; 'Eli Zaretskii'
> Objet : Re: [RFC] Require extern modifier for function prototypes in
> headers.
>
> On Wed, 19 Dec 2012 12:24:56 +0100, Pierre Muller wrote:
> > Joel proposed that I added a change to GDB coding styles.
>
> It was me, that we do not put it into Joel's mouth.

Whoops, sorry for the mistake.

> On Wed, 19 Dec 2012 22:48:11 +0100, Pierre Muller wrote:
> > > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > > owner@sourceware.org] De la part de Eli Zaretskii
> [...]
> > > If all declarations must be external, the _initialize_* case is no
> > > longer special, so the second sentence should go away, IMO.
> >
> > I thought that it was still special in the sense that they
> > are the only non-static functions that are not declared in headers,
> > but only inside the C source itself.
>
> I agree with the technical part said by Pierre here. So the doc change
> seems
> approved to me that way.
Thanks,

Patch applied in
http://sourceware.org/ml/gdb-cvs/2012-12/msg00174.html

Pierre Muller