From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21628 invoked by alias); 22 Dec 2012 12:54:03 -0000 Received: (qmail 21619 invoked by uid 22791); 22 Dec 2012 12:54:03 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,FAKE_REPLY_C,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 22 Dec 2012 12:53:57 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBMCrrS0008389 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 22 Dec 2012 07:53:53 -0500 Received: from host2.jankratochvil.net (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qBMCrmBi026020 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sat, 22 Dec 2012 07:53:51 -0500 Date: Sat, 22 Dec 2012 12:54:00 -0000 From: Jan Kratochvil To: Pierre Muller Cc: gdb-patches@sourceware.org, "'Eli Zaretskii'" Subject: Re: [RFC] Require extern modifier for function prototypes in headers. Message-ID: <20121222125347.GA6406@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <002201cdde32$8b3379b0$a19a6d10$@muller@ics-cnrs.unistra.fr> <000001cddddb$7999a0a0$6ccce1e0$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00778.txt.bz2 On Wed, 19 Dec 2012 12:24:56 +0100, Pierre Muller wrote: > Joel proposed that I added a change to GDB coding styles. It was me, that we do not put it into Joel's mouth. On Wed, 19 Dec 2012 22:48:11 +0100, Pierre Muller wrote: > > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > > owner@sourceware.org] De la part de Eli Zaretskii [...] > > If all declarations must be external, the _initialize_* case is no > > longer special, so the second sentence should go away, IMO. > > I thought that it was still special in the sense that they > are the only non-static functions that are not declared in headers, > but only inside the C source itself. I agree with the technical part said by Pierre here. So the doc change seems approved to me that way. Thanks, Jan