From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30776 invoked by alias); 18 Dec 2012 19:43:54 -0000 Received: (qmail 30753 invoked by uid 22791); 18 Dec 2012 19:43:53 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 19:43:42 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBIJhfJN001519 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 18 Dec 2012 14:43:41 -0500 Received: from host2.jankratochvil.net (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBIJhZM5017983 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 18 Dec 2012 14:43:39 -0500 Resent-From: Jan Kratochvil Resent-Date: Tue, 18 Dec 2012 20:43:35 +0100 Resent-Message-ID: <20121218194335.GA30106@host2.jankratochvil.net> Resent-To: sergiodj@redhat.com, binutils@sourceware.org, gdb-patches@sourceware.org, palves@redhat.com, hjl.tools@gmail.com Date: Tue, 18 Dec 2012 19:43:00 -0000 From: Jan Kratochvil To: Sergio Durigan Junior Cc: Binutils Development , GDB Patches , Pedro Alves , "H.J. Lu" Subject: Re: [PATCH/RFC 01/02 v2] Refactor PRPSINFO handling on Binutils Message-ID: <20121218193104.GA29194@host2.jankratochvil.net> References: <20121218173747.GA24546@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00663.txt.bz2 On Tue, 18 Dec 2012 20:19:06 +0100, Sergio Durigan Junior wrote: > On Tuesday, December 18 2012, Jan Kratochvil wrote: > The patch covers the existing targets that already implemented the > *_write_core_note function, with the exception of i386 which is a new > implementation. OK. > I disagree. As I said above, the patch covers all targets that were > already implementing *_write_core_note. If some new target decides to > implement it, it is just a matter of including "elf-psinfo.h" and using > the right structures. OK. > As I said above, I disagree. The header file is useful for having a > single place which defines those structures (i.e., i386, x32 and ARM use > the same elf_external_prpsinfo32 strucutre). That is a matter of opinion -> bfd maintainers, whether to copy the definition into each arch file or have some common header file for it despite it is compatible only with some of the archs. > Also, the header is useful > for including in the BFD clients (I'm thiking "GDB" here) which can use > the elf_internal_prpsinfo strucuture to pass information to BFD. I forgot about elf_internal_prpsinfo, that one needs to be included in BFD applications (like GDB). But elf_internal_prpsinfo should be then in a different file, maybe bfd.h? (I do not know much.) GDB does not need to know the elf_external_* layouts so those should not be defined in header file(s) available to GDB. Thanks, Jan