From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31497 invoked by alias); 18 Dec 2012 16:51:27 -0000 Received: (qmail 31489 invoked by uid 22791); 18 Dec 2012 16:51:23 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 16:50:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8FA502E467; Tue, 18 Dec 2012 11:50:47 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AQUPMm2IWRnU; Tue, 18 Dec 2012 11:50:47 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 13E232E465; Tue, 18 Dec 2012 11:50:46 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id BA8E5C394A; Tue, 18 Dec 2012 20:50:35 +0400 (RET) Date: Tue, 18 Dec 2012 16:51:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit 2/2] Import gnulib's errno module. Message-ID: <20121218165035.GI3273@adacore.com> References: <1355756839-11337-1-git-send-email-brobecker@adacore.com> <1355756839-11337-2-git-send-email-brobecker@adacore.com> <20121218060719.GD3273@adacore.com> <87r4mns49t.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r4mns49t.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00645.txt.bz2 > /* Some systems don't have EILSEQ, so we define it here, but not as > EINVAL, because callers of `iconv' want to distinguish EINVAL and > EILSEQ. This is what iconv.h from libiconv does as well. Note > that wchar.h may also define EILSEQ, so this needs to be after we > include wchar.h, which happens in defs.h through gdb_wchar.h. */ > #ifndef EILSEQ > #define EILSEQ ENOENT > #endif > > > My first thought was that we can now get rid of this define. > > But now I wonder whether this define will cause problems if we also > use libiconv; unless maybe the various header files are included in > the right order. I though libiconv had its own mechanism for defining EILSEQ. Do you think the two are going to interfere? -- Joel