Re: [patch v6 06/12] remote, btrace: add branch trace remote ops

Jan Kratochvil
2012-12-17T19:57:31Z

On Mon, 17 Dec 2012 17:01:35 +0100, markus.t.metzger@intel.com wrote:
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
[...]
> +/* Send the Qbtrace packet and check the response. */
> +
> +static void
> +send_Qbtrace (ptid_t ptid, int enable)
> +{
[...]
> + if (packet_ok (rs->buf, packet) == PACKET_ERROR)
> + error (_("Could not %s branch tracing for %s: %s"),
> + enable ? "enable" : "disable", target_pid_to_str (ptid), rs->buf);

"enable" and "disable" could be localized. (+use tab, not 8x space)

[...]
> +/* Check whether branch trace data has changed. */
> +
> +static int
> +remote_btrace_has_changed (struct btrace_target_info *tinfo)
> +{
[...]
> + if (strcmp (rs->buf, "yes") == 0)
> + return 1;

Incorrect indentation.

> +
> + if (strcmp (rs->buf, "no") == 0)
> + return 0;

Incorrect indentation.

> +
> + error (_("Bad remote reply: %s."), rs->buf);
> +
> + return 0;
> +}

Thanks,
Jan