From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28369 invoked by alias); 18 Dec 2012 09:04:45 -0000 Received: (qmail 28357 invoked by uid 22791); 18 Dec 2012 09:04:43 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 09:04:37 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBI94XW7009115 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 18 Dec 2012 04:04:33 -0500 Received: from host2.jankratochvil.net (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBI94S4K001384 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 18 Dec 2012 04:04:31 -0500 Date: Tue, 18 Dec 2012 09:04:00 -0000 From: Jan Kratochvil To: markus.t.metzger@intel.com Cc: palves@redhat.com, tromey@redhat.com, kettenis@gnu.org, gdb-patches@sourceware.org, markus.t.metzger@gmail.com Subject: Re: [patch v6 02/12] cli, btrace: add btrace cli Message-ID: <20121218090428.GE8054@host2.jankratochvil.net> References: <1355760101-26237-1-git-send-email-markus.t.metzger@intel.com> <1355760101-26237-3-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355760101-26237-3-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00625.txt.bz2 Hi Markus, I find new class excessive, feature specific to a single arch has a new "help" main menu entry now. For example existing - more powerful "record" feature is now under class_obscure. Maybe it could be class_run but so far I would put it together to "record", that is a bit unfortunate class_obscure. Thanks, Jan On Mon, 17 Dec 2012 17:01:31 +0100, markus.t.metzger@intel.com wrote: > diff --git a/gdb/command.h b/gdb/command.h > index 8eb86ba..b576b70 100644 > --- a/gdb/command.h > +++ b/gdb/command.h > @@ -39,7 +39,7 @@ enum command_class > no_class = -1, class_run = 0, class_vars, class_stack, class_files, > class_support, class_info, class_breakpoint, class_trace, > class_alias, class_bookmark, class_obscure, class_maintenance, > - class_pseudo, class_tui, class_user, class_xdb, > + class_pseudo, class_tui, class_user, class_xdb, class_btrace, > no_set_class /* Used for "show" commands that have no corresponding > "set" command. */ > }; > diff --git a/gdb/testsuite/gdb.base/page.exp b/gdb/testsuite/gdb.base/page.exp > index 0629807..d9b3899 100644 > --- a/gdb/testsuite/gdb.base/page.exp > +++ b/gdb/testsuite/gdb.base/page.exp > @@ -25,6 +25,7 @@ gdb_test_sequence "help" "unpaged help" { > "List of classes of commands:" > "" > "aliases -- Aliases of other commands" > + "branchtrace -- Recording a branch trace" > "breakpoints -- Making program stop at certain points" > "data -- Examining data" > "files -- Specifying and examining files" > @@ -52,12 +53,12 @@ gdb_expect_list "paged help" \ > "List of classes of commands:" > "" > "aliases -- Aliases of other commands" > + "branchtrace -- Recording a branch trace" > "breakpoints -- Making program stop at certain points" > "data -- Examining data" > "files -- Specifying and examining files" > "internals -- Maintenance commands" > "obscure -- Obscure features" > - "running -- Running the program" > } > gdb_test "q" > > -- > 1.7.6.5