From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11297 invoked by alias); 17 Dec 2012 20:35:03 -0000 Received: (qmail 10920 invoked by uid 22791); 17 Dec 2012 20:35:02 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Dec 2012 20:34:54 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBHKYqIB004071 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 17 Dec 2012 15:34:52 -0500 Received: from host2.jankratochvil.net (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBHKYlPs031310 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 17 Dec 2012 15:34:50 -0500 Date: Mon, 17 Dec 2012 20:35:00 -0000 From: Jan Kratochvil To: markus.t.metzger@intel.com Cc: palves@redhat.com, tromey@redhat.com, kettenis@gnu.org, gdb-patches@sourceware.org, markus.t.metzger@gmail.com Subject: Re: [patch v6 12/12] btrace, x86: disable on some processors Message-ID: <20121217203446.GJ14232@host2.jankratochvil.net> References: <1355760101-26237-1-git-send-email-markus.t.metzger@intel.com> <1355760101-26237-13-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355760101-26237-13-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00600.txt.bz2 On Mon, 17 Dec 2012 17:01:41 +0100, markus.t.metzger@intel.com wrote: > --- a/gdb/common/linux-btrace.c > +++ b/gdb/common/linux-btrace.c > @@ -247,7 +247,50 @@ perf_event_read_bts (struct btrace_target_info* tinfo, const uint8_t *begin, > int > linux_supports_btrace (void) > { > +#if defined(__i386__) || defined(__x86_64__) > + { [...] > + > +#else /* defined(__i386__) || defined(__x86_64__) */ BTW defined (__i386__) or defined __i386__ . http://www.gnu.org/prep/standards/standards.html#Comments Therefore: #if defined __i386__ || defined __x86_64__ but then negative: #else /* !defined __i386__ && !defined __x86_64__ */ #endif /* !defined __i386__ && !defined __x86_64__ */ (+cpuid comments in other mails) > + > + return 0; > + > +#endif /* defined(__i386__) || defined(__x86_64__) */ > } > > /* See linux-btrace.h. */ > -- > 1.7.6.5 Thanks, Jan