Re: [patch v6 02/12] cli, btrace: add btrace cli

Jan Kratochvil
2012-12-18T09:04:45Z

Hi Markus,

I find new class excessive, feature specific to a single arch has a new "help"
main menu entry now. For example existing - more powerful "record" feature is
now under class_obscure. Maybe it could be class_run but so far I would put
it together to "record", that is a bit unfortunate class_obscure.

Thanks,
Jan

On Mon, 17 Dec 2012 17:01:31 +0100, markus.t.metzger@intel.com wrote:
> diff --git a/gdb/command.h b/gdb/command.h
> index 8eb86ba..b576b70 100644
> --- a/gdb/command.h
> +++ b/gdb/command.h
> @@ -39,7 +39,7 @@ enum command_class
> no_class = -1, class_run = 0, class_vars, class_stack, class_files,
> class_support, class_info, class_breakpoint, class_trace,
> class_alias, class_bookmark, class_obscure, class_maintenance,
> - class_pseudo, class_tui, class_user, class_xdb,
> + class_pseudo, class_tui, class_user, class_xdb, class_btrace,
> no_set_class /* Used for "show" commands that have no corresponding
> "set" command. */
> };
> diff --git a/gdb/testsuite/gdb.base/page.exp b/gdb/testsuite/gdb.base/page.exp
> index 0629807..d9b3899 100644
> --- a/gdb/testsuite/gdb.base/page.exp
> +++ b/gdb/testsuite/gdb.base/page.exp
> @@ -25,6 +25,7 @@ gdb_test_sequence "help" "unpaged help" {
> "List of classes of commands:"
> ""
> "aliases -- Aliases of other commands"
> + "branchtrace -- Recording a branch trace"
> "breakpoints -- Making program stop at certain points"
> "data -- Examining data"
> "files -- Specifying and examining files"
> @@ -52,12 +53,12 @@ gdb_expect_list "paged help" \
> "List of classes of commands:"
> ""
> "aliases -- Aliases of other commands"
> + "branchtrace -- Recording a branch trace"
> "breakpoints -- Making program stop at certain points"
> "data -- Examining data"
> "files -- Specifying and examining files"
> "internals -- Maintenance commands"
> "obscure -- Obscure features"
> - "running -- Running the program"
> }
> gdb_test "q"
>
> --
> 1.7.6.5