Re: [patch v6 02/12] cli, btrace: add btrace cli

Jan Kratochvil
2012-12-18T08:35:29Z

On Tue, 18 Dec 2012 08:36:47 +0100, Metzger, Markus T wrote:
> I didn't use gdb_assert since this is not checking gdb's internal state. Gdb
> would still function correctly even if we saw such unexpected trace.

Sorry, I read a later patch where the data is read from XML from gdbserver so
I agree it should not be gdb_assert.

> > No need for a repost wrt the changes above.
>
> Does that mean you approve the patch?

Not yet, going to post yet a [patch 00/12] reply.

Thanks,
Jan