From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96862-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5344 invoked by alias); 11 Dec 2012 15:16:49 -0000
Received: (qmail 5334 invoked by uid 22791); 11 Dec 2012 15:16:47 -0000
X-SWARE-Spam-Status: No, hits=-3.0 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Dec 2012 15:16:40 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id qBBFGTOE005982;	Tue, 11 Dec 2012 16:16:29 +0100 (CET)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id qBBFGR58001045;	Tue, 11 Dec 2012 16:16:27 +0100 (CET)
Date: Tue, 11 Dec 2012 15:16:00 -0000
Message-Id: <201212111516.qBBFGR58001045@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: palves@redhat.com
CC: brobecker@adacore.com, gdb-patches@sourceware.org
In-reply-to: <20121211151136.GQ31477@adacore.com> (message from Joel Brobecker	on Tue, 11 Dec 2012 19:11:36 +0400)
Subject: Re: [PATCH 1/2] Put a NT_PSTATUS note on solaris cores.
References: <50C6115C.4090509@redhat.com> <20121210180216.3932.48633.stgit@brno.lan> <20121211030352.GB13565@adacore.com> <50C72573.5060305@redhat.com> <20121211151136.GQ31477@adacore.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00335.txt.bz2

> Date: Tue, 11 Dec 2012 19:11:36 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> 
> > You're doing the right test.  The issue is that core_pid_to_str
> > calls into the gdbarch_core_pid_to_str, and that isn't expecting
> > to be passed a "process pid" instead of an "LWP pid".
> > 
> > Could you try this one when you have a chance?  This is rebased on
> > top of current mainline, so it restores the elfcore_write_pstatus
> > call that the Unixware-excise patch removed.  I made sure it builds with
> > --enable-targets=all.
> 
> Nice detective work :)
> 
>     (gdb) core core.26444
>     [New LWP 1]
>     Core was generated by `/[...]/simple_main'.
>     Program terminated with signal 5, Trace/breakpoint trap.
>     #0  simple_main () at simple_main.adb:4
>     4           simple.test_simple;
>     (gdb) info inferiors
>       Num  Description       Executable
>     * 1    process 26444     /[...]/simple_main
> 
> And with an older core file, since your patch handles it too:
> 
>     (gdb) info inferiors
>       Num  Description       Executable
>     * 1    <core>            /[...]/simple_main
> 
> I tested the patch against our testsuite again, no regression either.
> So it looks all good to go!

FWIIW, this is fine with me as well (both the Unixware removal and
fixing the Solaris core dump stuff).