Re: [3/10] RFC: remove gdb_dirent.h

Joel Brobecker
2012-11-16T02:46:39Z

> * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add dirent.
> * common/gdb_dirent.h: Remove.
> * common/linux-osdata.c: Use <dirent.h>.
> (NAMELEN): Define.
> * config.in: Rebuild.
> * configure: Rebuild.
> * configure.ac: Don't call AC_HEADER_DIRENT.
> * gnulib/aclocal.m4: Update.
> * gnulib/configure: Update.
> * gnulib/import/Makefile.am: Update.
> * gnulib/import/Makefile.in: Update.
> * gnulib/import/dirent.in.h: Update.
> * gnulib/import/m4/dirent_h.m4: Update.
> * gnulib/import/m4/gnulib-cache.m4: Update.
> * gnulib/import/m4/gnulib-comp.m4: Update.
> * gnulib/import/m4/unistd_h.m4: Update.
> * linux-fork.c: Update.
> * linux-nat.c: Update.
> * nto-procfs.c: Update.
> * procfs.c: Update.
>
> * Makefile.in (linux-osdata.o): Don't reference gdb_dirent.h.
> * config.in: Rebuild.
> * configure: Rebuild.
> * configure.ac: Don't call AC_HEADER_DIRENT.

Looks good to me.

> -linux-osdata.o: ../common/linux-osdata.c $(server_h) $(linux_osdata_h) ../common/gdb_dirent.h
> +linux-osdata.o: ../common/linux-osdata.c $(server_h) $(linux_osdata_h)

Outch! I had forgotten about that. I had slowly and quietly convinced
myself that gdbserver also tracked dependencies automatically... :-/

--
Joel