From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14311 invoked by alias); 11 Dec 2012 03:04:25 -0000 Received: (qmail 14292 invoked by uid 22791); 11 Dec 2012 03:04:24 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Dec 2012 03:04:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1ACAB2E3A1; Mon, 10 Dec 2012 22:04:13 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id QBAST8yVyTxx; Mon, 10 Dec 2012 22:04:13 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A80292E0B7; Mon, 10 Dec 2012 22:04:12 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id BD009C3B05; Tue, 11 Dec 2012 07:03:52 +0400 (RET) Date: Tue, 11 Dec 2012 03:04:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Put a NT_PSTATUS note on solaris cores. Message-ID: <20121211030352.GB13565@adacore.com> References: <50C6115C.4090509@redhat.com> <20121210180216.3932.48633.stgit@brno.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121210180216.3932.48633.stgit@brno.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00293.txt.bz2 > 2012-12-10 Pedro Alves > > gdb/ > * procfs.c (procfs_make_note_section): Always output a NT_PSTATUS > note when NEW_PROC_API is defined. Tested on sparc-solaris, but it seems to have no effect yet: (gdb) core core.10498 [New LWP 1] Core was generated by `/[...]/simple_main'. Program terminated with signal 5, Trace/breakpoint trap. #0 simple_main () at simple_main.adb:4 4 simple.test_simple; (gdb) info inferiors Num Description Executable * 1 LWP 0 /[...]/simple_main And after the patch: (gdb) core core.15731 [New LWP 1] Core was generated by `/[...]/simple_main'. Program terminated with signal 5, Trace/breakpoint trap. #0 simple_main () at simple_main.adb:4 4 simple.test_simple; (gdb) info inferiors Num Description Executable * 1 LWP 0 /[...]/simple_main I can see that the second core file is bigger, but I am lacking the time to investigate this further at the moment. Maybe I am doing the wrong test? > --- > gdb/procfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/procfs.c b/gdb/procfs.c > index 82c7cd0..da5e158 100644 > --- a/gdb/procfs.c > +++ b/gdb/procfs.c > @@ -5544,7 +5544,7 @@ procfs_make_note_section (bfd *obfd, int *note_size) > > stop_signal = find_stop_signal (); > > -#ifdef UNIXWARE > +#ifdef NEW_PROC_API > fill_gregset (get_current_regcache (), &gregs, -1); > note_data = elfcore_write_pstatus (obfd, note_data, note_size, > PIDGET (inferior_ptid), -- Joel