From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20678 invoked by alias); 3 Dec 2012 13:21:36 -0000 Received: (qmail 20670 invoked by uid 22791); 3 Dec 2012 13:21:35 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Dec 2012 13:21:27 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB3DLPlC011388 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 3 Dec 2012 08:21:26 -0500 Received: from host2.jankratochvil.net (ovpn-116-104.ams2.redhat.com [10.36.116.104]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qB3DLL4K007552 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 3 Dec 2012 08:21:24 -0500 Date: Mon, 03 Dec 2012 13:21:00 -0000 From: Jan Kratochvil To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [patchv2] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename) Message-ID: <20121203132121.GA31046@host2.jankratochvil.net> References: <20121130185653.GA15394@host2.jankratochvil.net> <50BC7AB0.3070204@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50BC7AB0.3070204@broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00021.txt.bz2 On Mon, 03 Dec 2012 11:10:56 +0100, Andrew Burgess wrote: > I think we should consider switching some (or all) other places we print > symtab->filename to use the get_filename_display_from_sal function > instead. That was intended, I find the patch useless/buggy without it. "frame" worked fine but I have found for example this case does not: (gdb) frame #0 0x00007ffff637d7d0 in __poll_nocancel () at /usr/src/debug/glibc-2.16-75f0d304/sysdeps/unix/syscall-template.S:81 81 T_PSEUDO (SYSCALL_SYMBOL, SYSCALL_NAME, SYSCALL_NARGS) (gdb) info line *$pc Line 81 of "../sysdeps/unix/syscall-template.S" starts at address 0x7ffff637d7c0 and ends at 0x7ffff637d808 . > Even if this work is not done in this patch (which would be > fine with me) Not with me. > As such, I would rather the gdb option be "set filename-display" rather > than "set backtrace filename-display", I was thinking about such change before but I have left it according to the original submitters proposal which may match best where the users would search for it. OTOH when I check now the former thread it even did not come as the original submitters proposal so it could be changed. Thanks, Jan