From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12817 invoked by alias); 30 Nov 2012 15:16:32 -0000 Received: (qmail 12746 invoked by uid 22791); 30 Nov 2012 15:16:19 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Nov 2012 15:16:11 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAUFG8lN007477 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 30 Nov 2012 10:16:08 -0500 Received: from host2.jankratochvil.net (ovpn-116-104.ams2.redhat.com [10.36.116.104]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAUFG3UR006335 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 30 Nov 2012 10:16:06 -0500 Date: Fri, 30 Nov 2012 15:16:00 -0000 From: Jan Kratochvil To: "Metzger, Markus T" Cc: Tom Tromey , "gdb-patches@sourceware.org" , "markus.t.metzger@gmail.com" , "palves@redhat.com" , "kettenis@gnu.org" Subject: Re: [patch v4 03/13] cli, btrace: add btrace cli Message-ID: <20121130151603.GA8422@host2.jankratochvil.net> References: <1354013351-14791-1-git-send-email-markus.t.metzger@intel.com> <1354013351-14791-4-git-send-email-markus.t.metzger@intel.com> <87k3t6btlo.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00934.txt.bz2 On Fri, 30 Nov 2012 16:09:02 +0100, Metzger, Markus T wrote: > The easiest thing for me to do would be to only print "()" if lang != > language_cplus. Since the demangler prints the parameters right after the > function name, though, I would also remove the space before "()" for other > languages. http://www.gnu.org/prep/standards/standards.html#GNU-Manuals Please do not write ‘()’ after a function name just to indicate it is a function. foo () is not a function, it is a function call with no arguments. Regards, Jan