From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: proposal for branch patches after first release
Date: Thu, 29 Nov 2012 21:04:00 -0000 [thread overview]
Message-ID: <20121129210440.GL3581@adacore.com> (raw)
In-Reply-To: <50B78E0C.50607@redhat.com>
> > That'd be a nuisance, IMO, because some of them might be
> > NEWS-unworthy.
>
> I agree. And this results in a bit awkward NEWS file, in that we don't
> normally document bug fixes there, but point releases are usually
> only about bug fixes.
I agree it'd be pushing it for some commits (but I thought it'd
still be OK). Let's put that idea aside for now.
> > An alternative would be to require some predictably formatted string
> > in the log entry or the commit message, which you then could grep for.
> A one line at the head would be quite standard, given people have come
> used to mail subject == git commit summary. This might be the easiest,
> though making this a "branch-only" requirement is very error prone.
>
> I wouldn't mind at all enforcing better and more self-contained commit
> log style, FWIW.
While I agree it's a good idea to move towards this principle,
and for both head & branch, I think there is too much of a chance
for oversights.
> We could also make better use of bugzilla for this. I had stated my opinion
> on this <http://sourceware.org/ml/gdb-patches/2012-11/msg00395.html>:
[...]
> If people think the PR idea is too process burden for mainline, we could
> require this only for fixes that go into a release branch. E.g., tag
> the PRs with a special tag, e.g. "in-7.6.1".
Some of the commits in this release in fact did have a PR number,
and I was sometimes able to use that. But I noticed two issues:
1. It takes time to process each commit, and then go through
the various messages in the PR.
2. Often, I will still have to look into the code itself to really
figure out what the problem is. Take for instance PR gdb/14494
(http://sourceware.org/bugzilla/show_bug.cgi?id=14494). How
do I quickly write up a description of the problem actually fixed?
I also think that having the information spread out, be it in
the revision logs, or in a bugs database, makes it hard for anyone
who wants to figure out what changes exactly a minor release
contains and for what purpose.
For all these reasons, I think that having the developer write up
the description himself, with approval from Eli, and put it somewhere
in a file, would be best. If we want to call it known-problems or
anything else, instead of putting that info in the NEWS files,
that would be fine as well.
--
Joel
next prev parent reply other threads:[~2012-11-29 21:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 14:14 Joel Brobecker
2012-11-29 16:14 ` Eli Zaretskii
2012-11-29 16:32 ` Pedro Alves
2012-11-29 21:04 ` Joel Brobecker [this message]
2012-11-30 9:15 ` Eli Zaretskii
2012-11-30 10:55 ` Pedro Alves
2012-12-07 21:16 ` Tom Tromey
2012-12-03 6:51 ` Doug Evans
2012-12-03 9:16 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129210440.GL3581@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox