From: Joel Brobecker <brobecker@adacore.com>
To: Pavel Chupin <pavel.v.chupin@gmail.com>
Cc: Kai Tietz <ktietz70@googlemail.com>,
gdb-patches@sourceware.org, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH] Fix libtool.m4 dlopen lookup for mingw
Date: Tue, 27 Nov 2012 13:33:00 -0000 [thread overview]
Message-ID: <20121127133312.GB3581@adacore.com> (raw)
In-Reply-To: <CANwJu18Z_L9MuXy=3d3UTEucBjRmTH_93YwSebHgBm-hzuB=wg@mail.gmail.com>
> Looks like libtool.m4 is the right place to do such sort of checks.
> What do you think?
I cannot really answer that question authoratively, because the file
is maintained by GCC, as far as I can tell. In my opinion, and if I had
to write this check today, I'd probably do it differently, yes. For
instance, I would do all the dlopen tests, and if those fails, then
I would test for LoadLibrary as an alternative, etc. More generally
speaking, the recommended way of writing checks is to check for
features, rather than setting things up based on the type of system.
That being said, the current implementation kind of works, and enhancing
libtool.m4 might not be sufficient. I am not sure.
--
Joel
next prev parent reply other threads:[~2012-11-27 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 7:05 Pavel Chupin
2012-11-27 8:11 ` Joel Brobecker
2012-11-27 8:16 ` Kai Tietz
2012-11-27 12:17 ` Pavel Chupin
2012-11-27 13:33 ` Joel Brobecker [this message]
2012-11-27 14:58 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121127133312.GB3581@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=ktietz70@googlemail.com \
--cc=pavel.v.chupin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox