From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5144 invoked by alias); 26 Nov 2012 09:44:00 -0000 Received: (qmail 5133 invoked by uid 22791); 26 Nov 2012 09:44:00 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Nov 2012 09:43:52 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAQ9hovc009899 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 26 Nov 2012 04:43:50 -0500 Received: from host2.jankratochvil.net (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAQ9hkJd000889 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 26 Nov 2012 04:43:49 -0500 Date: Mon, 26 Nov 2012 09:44:00 -0000 From: Jan Kratochvil To: Tiago =?utf-8?Q?St=C3=BCrmer?= Daitx Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix printing functions with complex return on PPC64 Message-ID: <20121126094346.GA12249@host2.jankratochvil.net> References: <50a7b46b.6jsIRrSz9fiMZdfw%tdaitx@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <50a7b46b.6jsIRrSz9fiMZdfw%tdaitx@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00644.txt.bz2 On Sat, 17 Nov 2012 16:59:39 +0100, Tiago Stürmer Daitx wrote: > --- a/gdb/ppc-sysv-tdep.c > +++ b/gdb/ppc-sysv-tdep.c > @@ -1925,7 +1925,8 @@ ppc64_sysv_abi_return_value (struct gdbarch *gdbarch, struct value *function, > { > convert_typed_floating ((const bfd_byte *) writebuf + > i * (TYPE_LENGTH (valtype) / 2), > - valtype, regval, regtype); > + TYPE_TARGET_TYPE (valtype), regval, > + regtype); > regcache_cooked_write (regcache, > tdep->ppc_fp0_regnum + 1 + i, > regval); > @@ -1938,7 +1939,7 @@ ppc64_sysv_abi_return_value (struct gdbarch *gdbarch, struct value *function, > convert_typed_floating (regval, regtype, > (bfd_byte *) readbuf + > i * (TYPE_LENGTH (valtype) / 2), > - valtype); > + TYPE_TARGET_TYPE (valtype)); > } > } > } OK for commit. You could also replace TYPE_LENGTH (valtype) / 2 there by TYPE_LENGTH (TYPE_TARGET_TYPE (valtype)) to make it more clear (use some variable for TYPE_TARGET_TYPE (valtype); not required. Thanks, Jan