From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12019 invoked by alias); 17 Nov 2012 01:25:18 -0000 Received: (qmail 12009 invoked by uid 22791); 17 Nov 2012 01:25:17 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Nov 2012 01:25:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7A4C42E24E; Fri, 16 Nov 2012 20:25:11 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kVQX5-PKBS2p; Fri, 16 Nov 2012 20:25:11 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4AC8A2E248; Fri, 16 Nov 2012 20:25:11 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 942D4C269F; Fri, 16 Nov 2012 17:25:09 -0800 (PST) Date: Sat, 17 Nov 2012 01:25:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [4/10] RFC: unconditionally include signal.h Message-ID: <20121117012509.GA3234@adacore.com> References: <87obiyzns7.fsf@fleche.redhat.com> <87mwyiy8hi.fsf@fleche.redhat.com> <50A6755C.8040607@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50A6755C.8040607@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00477.txt.bz2 > > I think that checking for signal.h is pointless, because gdb already > > includes it unconditionally in various places -- e.g., utils.c. > > It's not pointless in gdbserver. The HAVE_SIGNAL_H checks were added for > the WinCE port. See fe7cf52e. Should we consider using gnulib's signal.h? -- Joel