From: Alan Modra <amodra@gmail.com>
To: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH] Fix gdb disassemble for power6/power7 instructions
Date: Tue, 13 Nov 2012 23:46:00 -0000 [thread overview]
Message-ID: <20121113234638.GI3056@bubble.grove.modra.org> (raw)
In-Reply-To: <1352785540-22911-1-git-send-email-emachado@linux.vnet.ibm.com>
On Tue, Nov 13, 2012 at 03:45:40AM -0200, Edjunior Barbosa Machado wrote:
> * ppc-dis.c (powerpc_init_dialect): If not defined, set
> info->disassembler_options to "any" or, if debugging an E500 binary,
> to "e500x2".
I don't like this change as it effectively disables later code that
tries to select a default, in particular breaking vle. The problem is
that the default code is somewhat lacking to say the least, and broken
in the way PPC_OPCODE_64 is handled.
What I think should happen is that the default handling, ie. the block
that starts with
if ((dialect & ~(ppc_cpu_t) PPC_OPCODE_64) == 0)
should be deleted and a switch on info->mach setting up dialect added
before we parse disassembler_options. That way -m32 and -m64 can
override the default as they are supposed to. See bfd/archures.c for
values of bfd_mach_ppc_*.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2012-11-13 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 5:46 Edjunior Barbosa Machado
2012-11-13 23:46 ` Alan Modra [this message]
2012-11-23 3:29 ` Alan Modra
2012-11-23 17:07 ` Edjunior Barbosa Machado
2012-11-28 18:38 ` Ulrich Weigand
2012-11-28 20:17 ` Edjunior Barbosa Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113234638.GI3056@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox