From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23489 invoked by alias); 12 Nov 2012 22:01:51 -0000 Received: (qmail 23481 invoked by uid 22791); 12 Nov 2012 22:01:50 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO,TW_CP X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Nov 2012 22:01:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 249751C7D94; Mon, 12 Nov 2012 17:01:46 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id OdUyS+qvz0dV; Mon, 12 Nov 2012 17:01:46 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DF60A1C7A95; Mon, 12 Nov 2012 17:01:45 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B6891C6725; Mon, 12 Nov 2012 14:01:29 -0800 (PST) Date: Mon, 12 Nov 2012 22:01:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Document replacement for frame_register_read (deprecated). Message-ID: <20121112220129.GX5103@adacore.com> References: <1350941919-9862-1-git-send-email-brobecker@adacore.com> <87objtf6mu.fsf@fleche.redhat.com> <20121112213157.GW5103@adacore.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="4SFOXa2GPu3tIq4H" Content-Disposition: inline In-Reply-To: <20121112213157.GW5103@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00302.txt.bz2 --4SFOXa2GPu3tIq4H Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 495 > For now, I'll do a quick and replace to clearly mark as deprecated. > If I have a little more time, I'll try to fix some of the current > uses... Attached is the patch that I just checked in. I tested it on x86_64-linux by building GDB with --enable-targets=all and I ran it through the testsuite, JIC. No regression. I'll keep this item on my list, to see if I can look at at least at the ones that are in the core part of GDB, and maybe at those that are for targets I can test. -- Joel --4SFOXa2GPu3tIq4H Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-rename-frame_register_read-into-deprecated_frame_reg.patch" Content-length: 8319 >From 11dfea93f9c607b1800394ce1d84f878ea82c37c Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Mon, 12 Nov 2012 13:48:55 -0800 Subject: [PATCH] rename frame_register_read into deprecated_frame_register_read. gdb/ChangeLog: * frame.h (deprecated_frame_register_read): Renames frame_register_read. * frame.c (deprecated_frame_register_read): Renames frame_register_read. Update all callers. * i386-tdep.c: Update all callers of frame_register_read. * infcmd.c: Likewise. * jit.c: Likewise. * mips-tdep.c: Likewise. * mt-tdep.c: Likewise. * sh64-tdep.c: Likewise. --- gdb/frame.c | 6 +++--- gdb/frame.h | 2 +- gdb/i386-tdep.c | 3 ++- gdb/infcmd.c | 2 +- gdb/jit.c | 4 ++-- gdb/mips-tdep.c | 6 +++--- gdb/mt-tdep.c | 8 ++++---- gdb/sh64-tdep.c | 4 ++-- 8 files changed, 18 insertions(+), 17 deletions(-) diff --git a/gdb/frame.c b/gdb/frame.c index 52498ba..bf034a8 100644 --- a/gdb/frame.c +++ b/gdb/frame.c @@ -776,7 +776,7 @@ get_frame_func (struct frame_info *this_frame) static enum register_status do_frame_register_read (void *src, int regnum, gdb_byte *buf) { - if (!frame_register_read (src, regnum, buf)) + if (!deprecated_frame_register_read (src, regnum, buf)) return REG_UNAVAILABLE; else return REG_VALID; @@ -1097,7 +1097,7 @@ put_frame_register (struct frame_info *frame, int regnum, Returns 0 if the register value could not be found. */ int -frame_register_read (struct frame_info *frame, int regnum, +deprecated_frame_register_read (struct frame_info *frame, int regnum, gdb_byte *myaddr) { int optimized; @@ -1218,7 +1218,7 @@ put_frame_register_bytes (struct frame_info *frame, int regnum, { gdb_byte buf[MAX_REGISTER_SIZE]; - frame_register_read (frame, regnum, buf); + deprecated_frame_register_read (frame, regnum, buf); memcpy (buf + offset, myaddr, curr_len); put_frame_register (frame, regnum, buf); } diff --git a/gdb/frame.h b/gdb/frame.h index c0559d9..1032904 100644 --- a/gdb/frame.h +++ b/gdb/frame.h @@ -673,7 +673,7 @@ extern struct frame_info *block_innermost_frame (const struct block *); extern int deprecated_pc_in_call_dummy (struct gdbarch *gdbarch, CORE_ADDR pc); -extern int frame_register_read (struct frame_info *frame, int regnum, +extern int deprecated_frame_register_read (struct frame_info *frame, int regnum, gdb_byte *buf); /* From stack.c. */ diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index b6879b9..f0056be 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -1783,7 +1783,8 @@ i386_frame_cache_1 (struct frame_info *this_frame, /* Saved stack pointer has been saved (but the SAVED_SP_REG register may be unavailable). */ if (cache->saved_sp == 0 - && frame_register_read (this_frame, cache->saved_sp_reg, buf)) + && deprecated_frame_register_read (this_frame, + cache->saved_sp_reg, buf)) cache->saved_sp = extract_unsigned_integer (buf, 4, byte_order); } /* Now that we have the base address for the stack frame we can diff --git a/gdb/infcmd.c b/gdb/infcmd.c index c3e602b..7a08e31 100644 --- a/gdb/infcmd.c +++ b/gdb/infcmd.c @@ -2155,7 +2155,7 @@ default_print_registers_info (struct gdbarch *gdbarch, val = allocate_value (regtype); /* Get the data in raw format. */ - if (! frame_register_read (frame, i, value_contents_raw (val))) + if (! deprecated_frame_register_read (frame, i, value_contents_raw (val))) mark_value_bytes_unavailable (val, 0, TYPE_LENGTH (value_type (val))); default_print_one_register_info (file, diff --git a/gdb/jit.c b/gdb/jit.c index 2dcafbc..1afbee6 100644 --- a/gdb/jit.c +++ b/gdb/jit.c @@ -1061,8 +1061,8 @@ jit_unwind_reg_get_impl (struct gdb_unwind_callbacks *cb, int regnum) gdb_reg = gdbarch_dwarf2_reg_to_regnum (frame_arch, regnum); size = register_size (frame_arch, gdb_reg); value = xmalloc (sizeof (struct gdb_reg_value) + size - 1); - value->defined = frame_register_read (priv->this_frame, gdb_reg, - value->value); + value->defined = deprecated_frame_register_read (priv->this_frame, gdb_reg, + value->value); value->size = size; value->free = reg_value_free_impl; return value; diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c index 61f2cd2..8140f23 100644 --- a/gdb/mips-tdep.c +++ b/gdb/mips-tdep.c @@ -6032,7 +6032,7 @@ mips_read_fp_register_single (struct frame_info *frame, int regno, int raw_size = register_size (gdbarch, regno); gdb_byte *raw_buffer = alloca (raw_size); - if (!frame_register_read (frame, regno, raw_buffer)) + if (!deprecated_frame_register_read (frame, regno, raw_buffer)) error (_("can't read register %d (%s)"), regno, gdbarch_register_name (gdbarch, regno)); if (raw_size == 8) @@ -6069,7 +6069,7 @@ mips_read_fp_register_double (struct frame_info *frame, int regno, { /* We have a 64-bit value for this register, and we should use all 64 bits. */ - if (!frame_register_read (frame, regno, rare_buffer)) + if (!deprecated_frame_register_read (frame, regno, rare_buffer)) error (_("can't read register %d (%s)"), regno, gdbarch_register_name (gdbarch, regno)); } @@ -6302,7 +6302,7 @@ print_gp_register_row (struct ui_file *file, struct frame_info *frame, break; /* End row: large register. */ /* OK: get the data in raw format. */ - if (!frame_register_read (frame, regnum, raw_buffer)) + if (!deprecated_frame_register_read (frame, regnum, raw_buffer)) error (_("can't read register %d (%s)"), regnum, gdbarch_register_name (gdbarch, regnum)); /* pad small registers */ diff --git a/gdb/mt-tdep.c b/gdb/mt-tdep.c index 0ae51b3..f45ebcf 100644 --- a/gdb/mt-tdep.c +++ b/gdb/mt-tdep.c @@ -685,7 +685,7 @@ mt_registers_info (struct gdbarch *gdbarch, buff = alloca (regsize); bytes = alloca (regsize * sizeof (*bytes)); - frame_register_read (frame, regnum, buff); + deprecated_frame_register_read (frame, regnum, buff); fputs_filtered (gdbarch_register_name (gdbarch, regnum), file); @@ -710,7 +710,7 @@ mt_registers_info (struct gdbarch *gdbarch, struct value_print_options opts; buf = alloca (register_size (gdbarch, MT_COPRO_REGNUM)); - frame_register_read (frame, MT_COPRO_REGNUM, buf); + deprecated_frame_register_read (frame, MT_COPRO_REGNUM, buf); /* And print. */ regnum = MT_COPRO_PSEUDOREG_REGNUM; fputs_filtered (gdbarch_register_name (gdbarch, regnum), @@ -731,13 +731,13 @@ mt_registers_info (struct gdbarch *gdbarch, gdb_byte buf[3 * sizeof (LONGEST)]; /* Get the two "real" mac registers. */ - frame_register_read (frame, MT_MAC_REGNUM, buf); + deprecated_frame_register_read (frame, MT_MAC_REGNUM, buf); oldmac = extract_unsigned_integer (buf, register_size (gdbarch, MT_MAC_REGNUM), byte_order); if (gdbarch_bfd_arch_info (gdbarch)->mach == bfd_mach_mrisc2 || gdbarch_bfd_arch_info (gdbarch)->mach == bfd_mach_ms2) { - frame_register_read (frame, MT_EXMAC_REGNUM, buf); + deprecated_frame_register_read (frame, MT_EXMAC_REGNUM, buf); ext_mac = extract_unsigned_integer (buf, register_size (gdbarch, MT_EXMAC_REGNUM), byte_order); } diff --git a/gdb/sh64-tdep.c b/gdb/sh64-tdep.c index e11e746..5d649df 100644 --- a/gdb/sh64-tdep.c +++ b/gdb/sh64-tdep.c @@ -1931,7 +1931,7 @@ sh64_do_fp_register (struct gdbarch *gdbarch, struct ui_file *file, alloca (register_size (gdbarch, gdbarch_fp0_regnum (gdbarch))); /* Get the data in raw format. */ - if (!frame_register_read (frame, regnum, raw_buffer)) + if (!deprecated_frame_register_read (frame, regnum, raw_buffer)) error (_("can't read register %d (%s)"), regnum, gdbarch_register_name (gdbarch, regnum)); @@ -2047,7 +2047,7 @@ sh64_do_register (struct gdbarch *gdbarch, struct ui_file *file, (gdbarch, regnum)), file); /* Get the data in raw format. */ - if (!frame_register_read (frame, regnum, raw_buffer)) + if (!deprecated_frame_register_read (frame, regnum, raw_buffer)) fprintf_filtered (file, "*value not available*\n"); get_formatted_print_options (&opts, 'x'); -- 1.7.9.5 --4SFOXa2GPu3tIq4H--