From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28369 invoked by alias); 12 Nov 2012 21:32:18 -0000 Received: (qmail 28361 invoked by uid 22791); 12 Nov 2012 21:32:18 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Nov 2012 21:32:14 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2137C2E02C; Mon, 12 Nov 2012 16:32:14 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Gwy3+ceEReBv; Mon, 12 Nov 2012 16:32:14 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E54A31C7B1B; Mon, 12 Nov 2012 16:32:13 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 9FE4AC5628; Mon, 12 Nov 2012 13:31:57 -0800 (PST) Date: Mon, 12 Nov 2012 21:32:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Document replacement for frame_register_read (deprecated). Message-ID: <20121112213157.GW5103@adacore.com> References: <1350941919-9862-1-git-send-email-brobecker@adacore.com> <87objtf6mu.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87objtf6mu.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00300.txt.bz2 > The patch seems reasonable to me. Thanks. I just checked it in. > Renaming seems like a decent idea, since there is a use in jit.c, which > was added long after this was deprecated. > > I count 22 mentions (including the declaration) of frame_register_read > in the tree right now. Getting rid of all of them doesn't seem so > difficult, aside from the testing. This would be clearly better... Yeah - I was hoping to have the time to do that, but I don't think it's completely straightforward. For now, I'll do a quick and replace to clearly mark as deprecated. If I have a little more time, I'll try to fix some of the current uses... -- Joel