From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28492 invoked by alias); 9 Nov 2012 10:04:05 -0000 Received: (qmail 28480 invoked by uid 22791); 9 Nov 2012 10:04:03 -0000 X-SWARE-Spam-Status: No, hits=-3.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Nov 2012 10:03:58 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id qA9A3qWa019821; Fri, 9 Nov 2012 11:03:52 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id qA9A3pUl018791; Fri, 9 Nov 2012 11:03:51 +0100 (CET) Date: Fri, 09 Nov 2012 10:04:00 -0000 Message-Id: <201211091003.qA9A3pUl018791@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: yao@codesourcery.com CC: mark.kettenis@xs4all.nl, gdb-patches@sourceware.org In-reply-to: <509C621D.9060406@codesourcery.com> (message from Yao Qi on Fri, 9 Nov 2012 09:53:33 +0800) Subject: Re: [RFC] Handle prologue on atom. References: <1350528745-5887-1-git-send-email-yao@codesourcery.com> <201210301041.q9UAfHNq010127@glazunov.sibelius.xs4all.nl> <509C621D.9060406@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00243.txt.bz2 > Date: Fri, 9 Nov 2012 09:53:33 +0800 > From: Yao Qi > CC: > X-OriginalArrivalTime: 09 Nov 2012 01:53:47.0866 (UTC) FILETIME=[0F00EBA0:01CDBE1D] > X-XS4ALL-DNSBL-Checked: mxdrop212.xs4all.nl checked 192.94.38.131 against DNS blacklists > X-CNFS-Analysis: v=2.0 cv=L5WqtZv8 c=1 sm=0 a=1K+y54S8amjD3nS2OSvmyw==:17 > a=8umaBx2KoyQA:10 a=4S5AUSBz4KsA:10 a=zbTXIsBlecMA:10 > a=8nJEP1OIZ-IA:10 a=lzDhS8hmAAAA:8 a=aKXOph7d5iEA:10 > a=a4xV_u6PtzGf4RH-6koA:9 a=wPNLvfGTeEIA:10 > a=1K+y54S8amjD3nS2OSvmyw==:117 > X-Virus-Scanned: by XS4ALL Virus Scanner > X-XS4ALL-Spam-Score: 0.0 () none > X-XS4ALL-Spam: NO > Envelope-To: mark.kettenis@xs4all.nl > > On 10/30/2012 06:41 PM, Mark Kettenis wrote: > > Thanks for the reminder Yao. The code looks ok, but the comments need > > a bit more work. I'll try to come up with a better wording, but > > unfortunately this week is extremely busy for me, so it'll probably be > > next week before I'll get back to you. > > Mark, do you have a chance to refine the comments? This patch fixes a > huge number of fails of test on atom, so I'd like to get it in as early > as we can. Bleah, no. If you don't mind me reorganizing the comments afterward, just go ahead and commit. The code is all good.