Re: [PATCH] Multi-process + multi-arch: GDB

Pedro Alves
2012-11-14T13:48:48Z

On 11/13/2012 08:50 PM, Tom Tromey wrote:
>>>>>> "Michael" == Michael Eager <eager@eagerm.com> writes:
>
> Michael> I'd recommend get_target_arch() rather than recasting
> Michael> target_gdbarch from a variable to a function. There are other
> Michael> get_target_* () functions and this would parallel that usage.
> Michael> Another benefit: a more substantive change in the name is less
> Michael> likely to be overlooked when adapting or backporting patches.
>
> In this particular case, I don't think there are big problems that can
> arise. target_gdbarch isn't used as a boolean, one of the major such
> issues that can possibly arise. Other issues, I think, will be caught
> by type-checking.

I agree problems aren't likely.

> That said, I don't really care all that much about the name, and if
> Pedro agrees I will rename it to something else.

I don't care about it that much myself either.
Renaming it to get_target_arch is of course fine with me, having
proposed it myself originally, if someone wants to do the work.

--
Pedro Alves