Re: [PATCH] Multi-process + multi-arch: GDB

Tom Tromey
2012-11-13T20:50:58Z

>>>>> "Michael" == Michael Eager <eager@eagerm.com> writes:

Michael> I'd recommend get_target_arch() rather than recasting
Michael> target_gdbarch from a variable to a function. There are other
Michael> get_target_* () functions and this would parallel that usage.
Michael> Another benefit: a more substantive change in the name is less
Michael> likely to be overlooked when adapting or backporting patches.

In this particular case, I don't think there are big problems that can
arise. target_gdbarch isn't used as a boolean, one of the major such
issues that can possibly arise. Other issues, I think, will be caught
by type-checking.

That said, I don't really care all that much about the name, and if
Pedro agrees I will rename it to something else.

Tom