should deprecated_target_gdbarch_select_hack be un-deprecated?

Pedro Alves
2012-11-09T19:40:41Z

On 11/09/2012 07:07 PM, Tom Tromey wrote:
>
> Finally, I wonder whether deprecated_target_gdbarch_select_hack should
> be un-deprecated. The comment says:
>
> /* Helper function. Set the global "target_gdbarch" to "gdbarch".
>
> FIXME: kettenis/20031124: Of the functions that follow, only
> gdbarch_from_bfd is supposed to survive. The others will
> dissappear since in the future GDB will (hopefully) be truly
> multi-arch. However, for now we're still stuck with the concept of
> a single active architecture. */
>
> It seems to me that we have settled on a somewhat different design; but
> also that the badness indicated by this comment no longer exists.

Yes, I think so. We used to do nasty things with swapping out gdbarch's
fields, which I believe would be the gross "hack" part, but that is gone.

--
Pedro Alves