From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12021 invoked by alias); 7 Nov 2012 19:21:27 -0000 Received: (qmail 12013 invoked by uid 22791); 7 Nov 2012 19:21:26 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,MSGID_FROM_MTA_HEADER,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e06smtp13.uk.ibm.com (HELO e06smtp13.uk.ibm.com) (195.75.94.109) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Nov 2012 19:21:19 +0000 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 7 Nov 2012 19:21:18 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 7 Nov 2012 19:21:16 -0000 Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qA7JL8v657802824 for ; Wed, 7 Nov 2012 19:21:08 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qA7JLEGR011290 for ; Wed, 7 Nov 2012 12:21:15 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id qA7JLDSI011279; Wed, 7 Nov 2012 12:21:13 -0700 Message-Id: <201211071921.qA7JLDSI011279@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 07 Nov 2012 20:21:13 +0100 Subject: Re: [PATCH] Fix PLT call stub for ppc64 To: emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado) Date: Wed, 07 Nov 2012 19:21:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <1352315215-30592-1-git-send-email-emachado@linux.vnet.ibm.com> from "Edjunior Barbosa Machado" at Nov 07, 2012 05:06:55 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit x-cbid: 12110719-2966-0000-0000-000005CE008D Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00164.txt.bz2 Edjunior Machado wrote: > GDB was unable to 'step' into a c/c++ function from a shared library on ppc64 > due to a change in linker that removes a load > instruction from the PLT call stub > (http://sourceware.org/ml/binutils/2011-07/msg00141.html). This patch fixes this > on GDB, marking the mentioned instruction as optional, since it still might > appear if the linker is called with '--plt-static-chain'. Hmm, looking at the binutils patch, it seems to me that the static chain load in the *other* PLT stubs (ppc64_standard_linkage1, ppc64_standard_linkage2) should now also be marked as optional, shouldn't it? Otherwise looks good to me. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com