From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13235 invoked by alias); 6 Nov 2012 20:01:33 -0000 Received: (qmail 13221 invoked by uid 22791); 6 Nov 2012 20:01:32 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Nov 2012 20:01:23 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA6K1Nxv026081 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 6 Nov 2012 15:01:23 -0500 Received: from host2.jankratochvil.net (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qA6K1ILP001403 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 6 Nov 2012 15:01:20 -0500 Date: Tue, 06 Nov 2012 20:01:00 -0000 From: Jan Kratochvil To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] bitpos expansion summary reloaded Message-ID: <20121106200117.GA4110@host2.jankratochvil.net> References: <20120927190053.1e7de264@spoyarek> <20120929173938.GA2987@host2.jankratochvil.net> <20120929181141.GA4009@host2.jankratochvil.net> <20120930065211.GA21118@host2.jankratochvil.net> <20121003184155.03dceed4@spoyarek> <20121003195627.GA17283@host2.jankratochvil.net> <20121004071314.GA4292@host2.jankratochvil.net> <20121021130546.02ea680c@spoyarek> <20121025155412.GA16619@host2.jankratochvil.net> <20121025222123.68c7b118@spoyarek> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121025222123.68c7b118@spoyarek> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00128.txt.bz2 On Thu, 25 Oct 2012 18:51:23 +0200, Siddhesh Poyarekar wrote: > On Thu, 25 Oct 2012 17:54:12 +0200, Jan wrote: > > we will go with the fix without the full -Wconversion fix. > > > > As most of the patches are very mechanical could you write a script > > which will try to separate the "clear" and human-review parts? > > > > "clear" I find that the patch is understood by the script (that is it > > is some s/int/LONGEST/ etc.) and that it does remove >= 1 > > -Wconversion warnings. > > > > Otherwise I will write such script. I hope it would "approve" most > > of the patches. > > It would be great if you could do this. I won't be able to get on it > this week. I have created the scripts below so far: http://people.redhat.com/jkratoch/conversiontest.pl http://people.redhat.com/jkratoch/buffer.c http://people.redhat.com/jkratoch/conversionsplit.pl But it will be still several weeks of work to split and verify all the patch chunks and after it is all done GDB will be still buggy wrt the 64-bit offsets safety as was shown below. Therefore going to drop it and start just normally fixing all the warnings for -Wconversion -Wno-sign-conversion where the number of warnings is several times larger but each such warning is simple and clear to fix. Unless someone has a better idea. Regards, Jan