Re: [PATCH,tests] Run to main before doing any tests in structs3.exp

[Joel Brobecker <brobecker@adacore.com>]

> On remote targets, we don't always start at the entry point. Thus,
> it is safer to get to main and do the tests from that point onwards.

Can you elaborate more? Your patch looks reasonable at first sight,
but then at the same time now introduces a new requirement that it
needs to be run on the target, whereas that was not the case before.

The testcase only prints global variables. I don't suppose there
is much of a guaranty that you could print global variables without
starting the program first, but it's been generally working. So
I am curious as to why it isn't working in your case.

> 2012-11-06  Luis Machado  <lgustavo@codesourcery.com>
> 
> 	* gdb.base/structs3.exp: Run to main before doing any tests.
> 
> Index: gdb-trunk/gdb/testsuite/gdb.base/structs3.exp
> ===================================================================
> --- gdb-trunk.orig/gdb/testsuite/gdb.base/structs3.exp	2012-11-02 17:29:00.801049370 -0200
> +++ gdb-trunk/gdb/testsuite/gdb.base/structs3.exp	2012-11-02 17:29:57.401050043 -0200
> @@ -23,6 +23,11 @@ if { [prepare_for_testing structs3.exp "
>      return -1
>  }
>  
> +if ![runto_main] {
> +    untested "could not run to main"
> +    return -1
> +}
> +
>  set vhn "\\$\[0-9\]+"
>  
>  # Check the real contents.


-- 
Joel