Re: [commit] off-by-one max exponent computation in convert_doublest_to_floatformat

[Joel Brobecker <brobecker@adacore.com>]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

On Thu, Oct 25, 2012 at 01:54:58AM +0200, Andreas Schwab wrote:
> You are still allowing the bug to happen.

Hmmm, yes, thank you. I was trying to handle the case where sizeof
long double is less than 8, but obviously, that's not the right
approach. I have applied the following patch that just removes "inf"
from the list of valid outputs. We'll make the output target-specific
if we find that we have to.

Tested on x86_64-linux.  Checked in.

-- 
Joel

[-- Attachment #2: 0001-gdb.base-ldbl_e308.exp-Do-not-allow-inf-in-value-out.patch --]
[-- Type: text/x-diff, Size: 1064 bytes --]

From e48d36c1af06cff4a602bc475c4acecc157b32dd Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Thu, 25 Oct 2012 07:11:32 -0400
Subject: [PATCH] gdb.base/ldbl_e308.exp: Do not allow "inf" in value output.

That was an attempt at handling the targets where sizeof(long double)
is less than 8, but the way it was implement allows the bug that
this testcase verifies to come back without being noticed.

gdb/testsuite/ChangeLog:

        * gdb.base/ldbl_e308.exp: Remove "inf" from possible expected
        output for "print inp" test.
---
 gdb/testsuite/gdb.base/ldbl_e308.exp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/ldbl_e308.exp b/gdb/testsuite/gdb.base/ldbl_e308.exp
index 89c54b5..ad9c5f4 100644
--- a/gdb/testsuite/gdb.base/ldbl_e308.exp
+++ b/gdb/testsuite/gdb.base/ldbl_e308.exp
@@ -27,5 +27,5 @@ if ![runto_main] {
 gdb_test_no_output "set variable ldbl_308 = 1.6e+308l"
 
 gdb_test "print ldbl_308" \
-         "= (1\..*e\\+308|inf)"
+         "= 1\..*e\\+308"
 
-- 
1.7.9.5