From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26407 invoked by alias); 24 Oct 2012 18:55:14 -0000 Received: (qmail 26396 invoked by uid 22791); 24 Oct 2012 18:55:13 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Oct 2012 18:55:08 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9OIt8Gn022437 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 24 Oct 2012 14:55:08 -0400 Received: from host2.jankratochvil.net (ovpn-116-77.ams2.redhat.com [10.36.116.77]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9OIt4TS020769 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 24 Oct 2012 14:55:06 -0400 Date: Wed, 24 Oct 2012 18:55:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: Siddhesh Poyarekar , gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] bitpos expansion summary reloaded Message-ID: <20121024185503.GA7794@host2.jankratochvil.net> References: <20120927190053.1e7de264@spoyarek> <20120929173938.GA2987@host2.jankratochvil.net> <20120929181141.GA4009@host2.jankratochvil.net> <20120930065211.GA21118@host2.jankratochvil.net> <20121003184155.03dceed4@spoyarek> <20121003195627.GA17283@host2.jankratochvil.net> <20121004071314.GA4292@host2.jankratochvil.net> <20121021130546.02ea680c@spoyarek> <20121023191049.GA17307@host2.jankratochvil.net> <87hapj90vf.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87hapj90vf.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00478.txt.bz2 On Wed, 24 Oct 2012 20:32:52 +0200, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > > Jan> (1) Check in the patchset as is while it is known not all type safety > Jan> regressions have been caught. > > Jan> (2) Fix all -Wconversion warnings, either by cast or by type extension, > Jan> depending on the case. But this can be done anytime later. > > I think we should start with (1). > > My rationale is that I consider the current patch set an improvement. > It may not be perfect, but it doesn't hurt anything, and I think the > various threads have shown that perfecting it as a precondition for > checking it in is too much to ask. To restate the perfection precondition reason - it was required before it has been found out for the really right solution we need to do full (2) anyway. Trying to automatically find all TYPE_LENGTH-derived values truncations would be impossible anymore after checking-in partial (1) and without the (2) fix. > This patch may make gdb uglier, in that we'll most likely add many new > casts to the code. I think the resulting additional safety is probably > worth it. Yes. > I'm curious what your opinion is. I didn't see it in your message. I think (2) - fixing -Wconversion should be done for GDB. With GDB there only always remains a question what is a priority of this task. This whole work has one flaw that GDB cannot access pieces of inferior objects. Therefore most of naive user operations with >4GB inferior objects will fail anyway. Which reminds priorities of GDB TODO items. Thanks, Jan