From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7067 invoked by alias); 24 Oct 2012 13:48:44 -0000 Received: (qmail 7058 invoked by uid 22791); 24 Oct 2012 13:48:43 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Oct 2012 13:48:34 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9ODmXMR018279 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Oct 2012 09:48:33 -0400 Received: from host2.jankratochvil.net (ovpn-116-77.ams2.redhat.com [10.36.116.77]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9ODmTfU030993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 24 Oct 2012 09:48:32 -0400 Date: Wed, 24 Oct 2012 13:48:00 -0000 From: Jan Kratochvil To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: [testsuite commit] Fix -m32 results [Re: [PATCH] Remove some KPASSes in gdb.base/callfuncs.exp] Message-ID: <20121024134828.GA24180@host2.jankratochvil.net> References: <201210231827.q9NIRdld028342@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201210231827.q9NIRdld028342@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00437.txt.bz2 On Tue, 23 Oct 2012 20:27:40 +0200, Mark Kettenis wrote: > Just fixed the bugs. Committed as obvious. It is a testsuite results regression in -m32 mode: --- 20121023Build-gdbcvs-f18/fedora-18-x86_64/out/gdb-m32.sum 2012-10-23 03:34:35.546531678 +0200 +++ 20121024Build-gdbcvs-f18/fedora-18-x86_64/out/gdb-m32.sum 2012-10-24 03:52:42.269267826 +0200 -KPASS: gdb.base/callfuncs.exp: call inferior func with struct - returns float _Complex (PRMS gdb/12796) -KFAIL: gdb.base/callfuncs.exp: call inferior func with struct - returns double _Complex (PRMS: gdb/12796) -KFAIL: gdb.base/callfuncs.exp: call inferior func with struct - returns long double _Complex (PRMS: gdb/12796) +PASS: gdb.base/callfuncs.exp: call inferior func with struct - returns float _Complex +FAIL: gdb.base/callfuncs.exp: call inferior func with struct - returns double _Complex +FAIL: gdb.base/callfuncs.exp: call inferior func with struct - returns long double _Complex This is because setup_kfail_for_target is broken by design. Checked in its workaround. There are more incorrect uses of setup_kfail_for_target but they already KPASS so asked in BZ for them: http://sourceware.org/bugzilla/show_bug.cgi?id=13808#c1 http://sourceware.org/bugzilla/show_bug.cgi?id=12790#c1 Regards, Jan http://sourceware.org/ml/gdb-cvs/2012-10/msg00100.html --- src/gdb/testsuite/ChangeLog 2012/10/23 18:25:24 1.3423 +++ src/gdb/testsuite/ChangeLog 2012/10/24 13:45:50 1.3424 @@ -1,3 +1,8 @@ +2012-10-24 Jan Kratochvil + + * gdb.base/callfuncs.exp (do_function_calls): Fix + setup_kfail_for_target for -m32 mode. + 2012-10-23 Mark Kettenis * gdb.base/callfuncs.exp: PR gdb/12796, gdb/12798 and gdb/12800 --- src/gdb/testsuite/gdb.base/callfuncs.exp 2012/10/23 18:25:25 1.54 +++ src/gdb/testsuite/gdb.base/callfuncs.exp 2012/10/24 13:45:51 1.55 @@ -245,11 +245,15 @@ gdb_test "p t_structs_fc(struct_val1)" ".*= 3 \\+ 3 \\* I" \ "call inferior func with struct - returns float _Complex" - setup_kfail_for_target gdb/12783 "i?86-*-*" + if [is_x86_like_target] { + setup_kfail gdb/12783 "*-*-*" + } gdb_test "p t_structs_dc(struct_val1)" ".*= 4 \\+ 4 \\* I" \ "call inferior func with struct - returns double _Complex" - setup_kfail_for_target gdb/12783 "i?86-*-*" + if [is_x86_like_target] { + setup_kfail gdb/12783 "*-*-*" + } gdb_test "p t_structs_ldc(struct_val1)" "= 5 \\+ 5 \\* I" \ "call inferior func with struct - returns long double _Complex" }