From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2534 invoked by alias); 23 Oct 2012 19:11:00 -0000 Received: (qmail 2526 invoked by uid 22791); 23 Oct 2012 19:10:59 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Oct 2012 19:10:54 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9NJAssf003712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 23 Oct 2012 15:10:54 -0400 Received: from host2.jankratochvil.net (ovpn-116-77.ams2.redhat.com [10.36.116.77]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9NJAojl028275 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 23 Oct 2012 15:10:52 -0400 Date: Tue, 23 Oct 2012 19:11:00 -0000 From: Jan Kratochvil To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] bitpos expansion summary reloaded Message-ID: <20121023191049.GA17307@host2.jankratochvil.net> References: <20120927190053.1e7de264@spoyarek> <20120929173938.GA2987@host2.jankratochvil.net> <20120929181141.GA4009@host2.jankratochvil.net> <20120930065211.GA21118@host2.jankratochvil.net> <20121003184155.03dceed4@spoyarek> <20121003195627.GA17283@host2.jankratochvil.net> <20121004071314.GA4292@host2.jankratochvil.net> <20121021130546.02ea680c@spoyarek> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline In-Reply-To: <20121021130546.02ea680c@spoyarek> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00428.txt.bz2 Hi Siddhesh, in the mail http://sourceware.org/ml/gdb-patches/2012-09/msg00706.html I have reported bitpos-patched GDB has the problem on line ada-valprint.c:700. I do see this incomplete extension neither fixed nor listed in the gcc-warnings.out.report file. I see why, the line had the -Wconversion warning even before so it correctly did not appear in the .report. But there is missing a bitpos extension now. When I run -Wconversion by hand I do get: ada-valprint.c: In function ‘ada_val_print_1’: ada-valprint.c:700:68: error: conversion to ‘int’ from ‘long int’ may alter its value [-Werror=conversion] while on the unpatched source tree one gets: ada-valprint.c: In function ‘ada_val_print_1’: ada-valprint.c:699:68: error: conversion to ‘int’ from ‘long int’ may alter its value [-Werror=conversion] Unless one carefully checks all the uses of any extended variable - which I was doing occasionally by hand but I understand it is very fragile to do in all the cases by hand - this method does not work. So there are these options: (1) Check in the patchset as is while it is known not all type safety regressions have been caught. (2) Fix all -Wconversion warnings, either by cast or by type extension, depending on the case. But this can be done anytime later. The whole review effort improved the quality of (1) but it is still not a 100% fix. Fortunately (2) can be done in parts, (1) could not have been done in parts as one cannot separate former -Wconversion vs. latter -Wconversion messages. But it has been shown (1) cannot be done perfectly without (2). Regards, Jan