From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5617 invoked by alias); 23 Oct 2012 13:55:09 -0000 Received: (qmail 5609 invoked by uid 22791); 23 Oct 2012 13:55:08 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Oct 2012 13:55:05 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5042A1C7F60; Tue, 23 Oct 2012 09:55:05 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id bHNbzvzPkhap; Tue, 23 Oct 2012 09:55:05 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 86DBA1C7E96; Tue, 23 Oct 2012 09:55:03 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 08B2DC7F67; Tue, 23 Oct 2012 09:55:02 -0400 (EDT) Date: Tue, 23 Oct 2012 13:55:00 -0000 From: Joel Brobecker To: Kaushik Phatak Cc: Yao Qi , "gdb-patches@sourceware.org" Subject: Re: [RFA 3/5] New port: CR16: gdb port Message-ID: <20121023135502.GA3555@adacore.com> References: <507279C7.8080401@codesourcery.com> <20121022224107.GB3713@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00413.txt.bz2 > These globals are actually declared in /opcodes/cr16-dis.c and my > earlier version of this patch had declared them extern here. > Converting the disassembler piece of code would be bit tricky as > print_insn_cr16 and print_arg seem to use these globals directly. > Would it be OK just to leave them as extern here with appropriate > comments? Can you declare those externs somewhere in opcode instead? That way, both opcode and GDB would use the same declaration, and that would ensure consistency. > I will make that change for unwind_pc and unwind_sp as well. The locals helped > me debug my code better, but I can remove them now. You do not have to, if you prefer it the other way. But I would make sure that the type of the variables match the return type. > I think I can remove this fixme as the issue is actually at the sim end. > The host side gdb gets correct information about data types directly from > the symbol table. The simulator totally gets lost when -mint32 is passed. Cool :). -- Joel