From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 779 invoked by alias); 21 Oct 2012 01:56:55 -0000 Received: (qmail 771 invoked by uid 22791); 21 Oct 2012 01:56:54 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 21 Oct 2012 01:56:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1A88C1C68F1; Sat, 20 Oct 2012 21:56:50 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5wY3kmOuq2kn; Sat, 20 Oct 2012 21:56:50 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DD70A1C6838; Sat, 20 Oct 2012 21:56:49 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id F327FC7B2A; Sat, 20 Oct 2012 18:56:36 -0700 (PDT) Date: Sun, 21 Oct 2012 01:56:00 -0000 From: Joel Brobecker To: "H.J. Lu" Cc: GDB Subject: Re: [7.5] PATCH: PR backtrace/14646 [x32] backtrace doesn't work Message-ID: <20121021015636.GD3050@adacore.com> References: <20121020234741.GA3626@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121020234741.GA3626@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00372.txt.bz2 > This patch backports the fix from trunk to 7.5 branch. Tested on > Linux/x86-64 and Linux/x32. OK to install? [...] > PR backtrace/14646 > PR gdb/14647 > * i386-tdep.h (gdbarch_tdep): Remove sp_regnum_from_eax and > pc_regnum_from_eax. > * i386-tdep.c (i386_gdbarch_init): Don't use sp_regnum_from_eax > nor pc_regnum_from_eax. > * amd64-tdep.c (amd64_x32_init_abi): Don't set sp_regnum_from_eax > nor pc_regnum_from_eax. I'm sorry to say that I am not comfortable at all with this going in the 7.5 branch. If Mark is super confident, then OK, but this is touching sp/pc handling for all x86 and x86-64 targets. And I don't think that the issue this patch is fixing is that critical. -- Joel